-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed unused variables: This should fix the gcc7 compilation issues #20390
Conversation
Original changes were proposed by @ashtipliyski here ashtipliyski@d04e83d
please test |
The tests are being triggered in jenkins. |
The code-checks are being triggered in jenkins. |
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master. It involves the following packages: DQM/L1TMonitor @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks |
@davidlange6 , can we get this in 93X before 11h00. although tests are running but they look good. This PR just remove unused variables , so compilation is a good enough test for this :-) |
yes- if you see the compilation is done, go ahead and merge...
… On Sep 6, 2017, at 10:05 AM, Malik Shahzad Muzaffar ***@***.***> wrote:
@davidlange6 , can we get this in 93X before 11h00. although tests are running but they look good. This PR just remove unused variables , so compilation is a good enough test for this :-)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Original changes were proposed by @ashtipliyski here ashtipliyski@d04e83d