Update HcalSeverityLevelComputer to be able to use both phase0 and phase1 flags #19532

jaehyeok · 2017-07-03T22:24:18Z

This is an update on the HcalSeverityLevelComputer and the relevant codes such that the phase 1 RecHit flags can be used.

Needed in order to use the RecHit cleaning based on the charge asymmetry between two anodes because the current HcalSeverityLevelComputer does not support it
Added a parameter called “phase” so that the correct set of flags (phase0 vs phase1) is chosen by era
For back-compatibility, the current flags (phase0) are not touched
Added an option to RecoLocalCalo/HcalRecAlgos/python/RemoveAddSevLevel.py so that warning messages can be suppressed if necessary

…od_cfi.py still needs to be updated)

…phase1 Fixes & reduce code duplication

…= 5 flags

…omputer does not print out error message

…phase1 Add filldescriptions and remove warning

cmsbuild · 2017-07-03T22:24:35Z

A new Pull Request was created by @jaehyeok for master.

It involves the following packages:

Configuration/DataProcessing
Configuration/StandardSequences
RecoLocalCalo/HcalRecAlgos

@perrotta, @cmsbuild, @franzoni, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @ebrondol, @mariadalfonso, @argiro, @dgulhan this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

kpedro88 · 2017-07-03T22:26:10Z

please test

cmsbuild · 2017-07-03T22:26:27Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21111/console Started: 2017/07/04 00:58

kpedro88 · 2017-07-03T22:26:46Z

@fwyzard FYI, this will have to be updated in corresponding HLT configs for 2017 at some point

fwyzard · 2017-07-03T22:41:40Z

Thanks.

We will also need a 9.2.x backport, then.

kpedro88 · 2017-07-03T22:46:58Z

@jaehyeok you should be able to submit another PR from this same branch to the CMSSW_9_2_X branch

cmsbuild · 2017-07-22T03:35:13Z

-1

Tested at: bd72628

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
be34a0d
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19532/21683/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19532/21683/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19532/21683/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals AddOn

Unit Tests:

I found errors in the following unit tests:

---> test testRecoMETMETProducers had ERRORS

RelVals:

When I ran the RelVals I found an error in the following worklfows:
4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log

140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

8.0 step3

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step3_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

136.731 step3

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

10042.0 step2

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step2_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

10024.0 step2

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10824.0 step2

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018.log

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

50202.0 step3

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

20034.0 step3

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17.log

20434.0 step3

runTheMatrix-results/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D19_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D19+RecoFullGlobal_2023D19+HARVESTFullGlobal_2023D19/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D19_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D19+RecoFullGlobal_2023D19+HARVESTFullGlobal_2023D19.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Sat Jul 22 05:28:43 2017-date Sat Jul 22 05:28:03 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_DATA.root --fileout file:RelVal_Raw_Fake2_DATA_HLT_RECO.root : FAILED - time: date Sat Jul 22 05:29:20 2017-date Sat Jul 22 05:28:09 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02481/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-21-1100/src/HLTrigger/Configuration/test/OnLine_HLT_2e34_v2.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Sat Jul 22 05:33:52 2017-date Sat Jul 22 05:28:14 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:2e34_v2,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_2e34_v2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_2e34_v2_MC.root --fileout file:RelVal_Raw_2e34_v2_MC_HLT_RECO.root : FAILED - time: date Sat Jul 22 05:33:52 2017-date Sat Jul 22 05:28:14 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02481/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-21-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Sat Jul 22 05:29:24 2017-date Sat Jul 22 05:28:18 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Sat Jul 22 05:29:24 2017-date Sat Jul 22 05:28:18 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02481/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-21-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Sat Jul 22 05:29:32 2017-date Sat Jul 22 05:28:21 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=HeavyIons -n 10 --conditions auto:run2_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Sat Jul 22 05:29:32 2017-date Sat Jul 22 05:28:21 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02481/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-21-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Sat Jul 22 05:33:49 2017-date Sat Jul 22 05:28:25 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Sat Jul 22 05:33:49 2017-date Sat Jul 22 05:28:25 2017 s - exit: 18688
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - time: date Sat Jul 22 05:29:16 2017-date Sat Jul 22 05:28:29 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02481/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-21-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Sat Jul 22 05:33:58 2017-date Sat Jul 22 05:28:33 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Sat Jul 22 05:33:58 2017-date Sat Jul 22 05:28:33 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02481/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-21-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Sat Jul 22 05:34:08 2017-date Sat Jul 22 05:28:38 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Sat Jul 22 05:34:08 2017-date Sat Jul 22 05:28:38 2017 s - exit: 18688
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - time: date Sat Jul 22 05:29:34 2017-date Sat Jul 22 05:28:42 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02481/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-21-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Sat Jul 22 05:31:21 2017-date Sat Jul 22 05:28:45 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Sat Jul 22 05:31:21 2017-date Sat Jul 22 05:28:45 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_MC.root --fileout file:RelVal_Raw_Fake_MC_HLT_RECO.root : FAILED - time: date Sat Jul 22 05:33:57 2017-date Sat Jul 22 05:28:47 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02481/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-21-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Sat Jul 22 05:33:34 2017-date Sat Jul 22 05:28:50 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Sat Jul 22 05:33:34 2017-date Sat Jul 22 05:28:50 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_MC.root --fileout file:RelVal_Raw_Fake2_MC_HLT_RECO.root : FAILED - time: date Sat Jul 22 05:34:19 2017-date Sat Jul 22 05:28:51 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_MC.root --fileout file:RelVal_Raw_Fake1_MC_HLT_RECO.root : FAILED - time: date Sat Jul 22 05:34:17 2017-date Sat Jul 22 05:28:54 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run1_data_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_DATA.root --fileout file:RelVal_Raw_Fake_DATA_HLT_RECO.root : FAILED - time: date Sat Jul 22 05:33:03 2017-date Sat Jul 22 05:28:59 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02481/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-21-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Sat Jul 22 05:33:27 2017-date Sat Jul 22 05:29:04 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Sat Jul 22 05:33:27 2017-date Sat Jul 22 05:29:04 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_DATA.root --fileout file:RelVal_Raw_Fake1_DATA_HLT_RECO.root : FAILED - time: date Sat Jul 22 05:33:05 2017-date Sat Jul 22 05:29:05 2017 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02481/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_9_3_X_2017-07-21-1100/src/HLTrigger/Configuration/test/OnLine_HLT_2e34_v2.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Sat Jul 22 05:33:28 2017-date Sat Jul 22 05:29:10 2017 s - exit: 18688
cmsDriver.py RelVal -s HLT:2e34_v2,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_2e34_v2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_2e34_v2_DATA.root --fileout file:RelVal_Raw_2e34_v2_DATA_HLT_RECO.root : FAILED - time: date Sat Jul 22 05:33:28 2017-date Sat Jul 22 05:29:10 2017 s - exit: 18688

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
be34a0d
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19532/21683/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19532/21683/git-merge-result

cmsbuild · 2017-07-22T03:35:16Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2017-07-22T20:32:49Z

Pull request #19532 was updated. @perrotta, @cmsbuild, @franzoni, @slava77, @davidlange6 can you please check and sign again.

kpedro88 · 2017-07-22T20:37:30Z

Please test

cmsbuild · 2017-07-22T20:37:47Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21690/console Started: 2017/07/22 22:39

cmsbuild · 2017-07-22T23:20:06Z

+1
Tested at: a3c7cf8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19532/21690/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
9a401ab
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19532/21690/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19532/21690/git-merge-result

cmsbuild · 2017-07-22T23:20:08Z

Comparison job queued.

cmsbuild · 2017-07-23T02:50:40Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19532/21690/summary.html

Comparison Summary:

You potentially added 5 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 2355459
DQMHistoTests: Total failures: 29456
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2325837
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 93 log files, 14 edm output root files, 23 DQM output files

perrotta · 2017-07-24T09:26:21Z

+1

The module configuration previously in hcalRecAlgoESProd_cfi.py is now correctly moved to the fillDescriptions() method, which also gets rid of the setAllowAnything flag.
For the rest, the same considerations as in Update HcalSeverityLevelComputer to be able to use both phase0 and phase1 flags #19532 (comment) still hold.

abdoulline · 2017-07-24T21:02:21Z

@davidlange6
David, may we get it unheld now?

davidlange6 · 2017-07-26T05:54:05Z

merge

jaehyeok and others added 13 commits June 27, 2017 02:39

first shot at the changing HcalSeverityLevelComputer (hcalRecAlgoESPr…

aee7f56

…od_cfi.py still needs to be updated)

Era-dependent HcalCaloFlagLabels setting

bca1e1d

Era-dependent HcalCaloFlagLabels setting

34d2d6b

address code review issues

a570691

reduce code duplication in phase1 update to severity levels

b711afe

Merge pull request #1 from kpedro88/update-HcalSeverityLevelComputer-…

234ee9c

…phase1 Fixes & reduce code duplication

Change the severitylevel for TimingFromTDC to 0. Keep phase0 sev lvl …

6e79de9

…= 5 flags

clean Severity level=5 and RecoveredRecHitBits flags so SeveritLevelC…

24fdfc0

…omputer does not print out error message

change phase_ to unsigned int

83fcbea

remove HFDigiTime flag in Run2_2017

f1711c3

minimal fillDescriptions() for new parameter

91dc5d4

remove warning message for HFDigiTime

ce952c0

Merge pull request #2 from kpedro88/update-HcalSeverityLevelComputer-…

7f06d21

…phase1 Add filldescriptions and remove warning

cmsbuild added this to the CMSSW_9_3_X milestone Jul 3, 2017

cmsbuild added comparison-pending operations-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jul 3, 2017

cmsbuild added tests-started and removed tests-pending labels Jul 3, 2017

Turn on noise filters used in 2016

54b4894

cmsbuild removed the tests-started label Jul 3, 2017

cmsbuild added the tests-started label Jul 22, 2017

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Jul 22, 2017

full definition of parameters in fillDescriptions

a3c7cf8

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Jul 22, 2017

cmsbuild added tests-started and removed tests-pending labels Jul 22, 2017

cmsbuild added tests-approved and removed tests-started labels Jul 22, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jul 23, 2017

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jul 24, 2017

cmsbuild merged commit c80401f into cms-sw:master Jul 26, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update HcalSeverityLevelComputer to be able to use both phase0 and phase1 flags #19532

Update HcalSeverityLevelComputer to be able to use both phase0 and phase1 flags #19532

jaehyeok commented Jul 3, 2017

cmsbuild commented Jul 3, 2017

kpedro88 commented Jul 3, 2017

cmsbuild commented Jul 3, 2017 •

edited

Loading

kpedro88 commented Jul 3, 2017

fwyzard commented Jul 3, 2017

kpedro88 commented Jul 3, 2017

cmsbuild commented Jul 22, 2017

cmsbuild commented Jul 22, 2017

cmsbuild commented Jul 22, 2017

kpedro88 commented Jul 22, 2017

cmsbuild commented Jul 22, 2017 •

edited

Loading

cmsbuild commented Jul 22, 2017

cmsbuild commented Jul 22, 2017

cmsbuild commented Jul 23, 2017

perrotta commented Jul 24, 2017

abdoulline commented Jul 24, 2017 •

edited

Loading

davidlange6 commented Jul 26, 2017

Update HcalSeverityLevelComputer to be able to use both phase0 and phase1 flags #19532

Update HcalSeverityLevelComputer to be able to use both phase0 and phase1 flags #19532

Conversation

jaehyeok commented Jul 3, 2017

cmsbuild commented Jul 3, 2017

kpedro88 commented Jul 3, 2017

cmsbuild commented Jul 3, 2017 • edited Loading

kpedro88 commented Jul 3, 2017

fwyzard commented Jul 3, 2017

kpedro88 commented Jul 3, 2017

cmsbuild commented Jul 22, 2017

cmsbuild commented Jul 22, 2017

cmsbuild commented Jul 22, 2017

kpedro88 commented Jul 22, 2017

cmsbuild commented Jul 22, 2017 • edited Loading

cmsbuild commented Jul 22, 2017

cmsbuild commented Jul 22, 2017

cmsbuild commented Jul 23, 2017

perrotta commented Jul 24, 2017

abdoulline commented Jul 24, 2017 • edited Loading

davidlange6 commented Jul 26, 2017

cmsbuild commented Jul 3, 2017 •

edited

Loading

cmsbuild commented Jul 22, 2017 •

edited

Loading

abdoulline commented Jul 24, 2017 •

edited

Loading