A correct description of the HL-LHC beamspot #16942

lgray · 2016-12-09T10:14:54Z

This PR changes the HL-LHC beamspot simulation we are using to be exactly the HL-LHC beamspot simulation from the HL-LHC machine group.

This PR is waiting for one more item: a correct description of the x and y distribution of vertices in the beamspot.

The online beamspot doesn't need to be updated as the major change here is for the width of the beamspot in time, and the online beamspot only has spatial coordinates. There is a slight change in the beamspot z width but it does not invalidate the beamspot in the database.

Vertex profile in time (axis is ns, arb units):

Vertex profile in z (axis in cm, normalized to ev/mm in 140 PU):

Vertex shape in z and time (arb units):

@davidlange6 It would be good to get this in for the tracker TDR production, I also found a weird bug in the old HL-LHC beamspot such that x and z were correlated (which should not be the case!).

cmsbuild · 2016-12-09T10:15:11Z

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_9_0_X.

It involves the following packages:

IOMC/EventVertexGenerators

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

lgray · 2016-12-09T10:16:23Z

@cmsbuild please test

Reminder - this PR only has the z and time coordinates cross-validated with the HL-LHC machine group. X and Y should come soon.

@kpedro88

cmsbuild · 2016-12-09T10:16:38Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16891/console Started: 2016/12/09 11:17

cmsbuild · 2016-12-09T11:05:41Z

-1

Tested at: 5f33356

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16942/16891/summary.html

I found follow errors while testing this PR

Failed tests: ClangBuild

Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 48 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2016-12-08-2300/src/IOMC/EventVertexGenerators/src/GaussEvtVtxGenerator.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2016-12-08-2300/src/IOMC/EventVertexGenerators/src/GaussianZBeamSpotFilter.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2016-12-08-2300/src/IOMC/EventVertexGenerators/src/BetafuncEvtVtxGenerator.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2016-12-08-2300/src/IOMC/EventVertexGenerators/test/VtxTester.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2016-12-08-2300/src/IOMC/EventVertexGenerators/test/BoostTester.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2016-12-08-2300/src/IOMC/EventVertexGenerators/src/HLLHCEvtVtxGenerator.cc:25:20: error: constexpr variable 'two_pi' must be initialized by a constant expression
  constexpr double two_pi=8.0*std::atan(1.0);
                   ^      ~~~~~~~~~~~~~~~~~~
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2016-12-08-2300/src/IOMC/EventVertexGenerators/src/HLLHCEvtVtxGenerator.cc:25:31: note: non-constexpr function 'atan' cannot be used in a constant expression
  constexpr double two_pi=8.0*std::atan(1.0);
                              ^

cmsbuild · 2016-12-09T11:05:44Z

Comparison job queued.

cmsbuild · 2016-12-09T11:13:40Z

Pull request #16942 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again.

lgray · 2016-12-09T11:14:23Z

@cmsbuild please test

cmsbuild · 2016-12-09T11:14:39Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16893/console Started: 2016/12/09 12:16

cmsbuild · 2016-12-09T12:01:58Z

-1

Tested at: 2bb5d9d

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16942/16893/summary.html

I found follow errors while testing this PR

Failed tests: ClangBuild

Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 64 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

  const double dx_plus  = (z-t*ct)*(cax*st_plus-sax_plus*ct)   - (x-t*st_plus)*(sax_plus*st_plus+cax*ct);
               ^
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2016-12-08-2300/src/IOMC/EventVertexGenerators/src/HLLHCEvtVtxGenerator.cc:151:20: warning: unused variable 'c' [-Wunused-variable]
  constexpr double c= 2.99792458e+8; // m/s
                   ^
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2016-12-08-2300/src/IOMC/EventVertexGenerators/src/HLLHCEvtVtxGenerator.cc:203:20: error: constexpr variable 'factorRMSgauss4' must be initialized by a constant expression
  constexpr double factorRMSgauss4  = 1./std::sqrt(2.)/gamma34 * gamma14; // # Factor to take rms sigma as input of the supergaussian
                   ^                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2016-12-08-2300/src/IOMC/EventVertexGenerators/src/HLLHCEvtVtxGenerator.cc:203:42: note: non-constexpr function 'sqrt' cannot be used in a constant expression
  constexpr double factorRMSgauss4  = 1./std::sqrt(2.)/gamma34 * gamma14; // # Factor to take rms sigma as input of the supergaussian
                                         ^

cmsbuild · 2016-12-09T12:02:01Z

Comparison job queued.

lgray · 2016-12-11T14:08:35Z

@kpedro88 could you unhold, I have confirmation from Rogelio Garcia (HL-LHC guy) that this looks good. I am doing a few final checks.

lgray · 2016-12-11T15:15:35Z

Here are the beam profiles for the default parameters of this validated HL-LHC beamspot simulation. This is for 200PU.

profile in x (arb units):

profile in y (arb units):

profile in z (ev/mm):

profile in t (arb units):

2D space vs. time profiles (arb units):

2D spatial profiles (arb units):

lgray · 2016-12-11T15:21:59Z

Hold on, this has some effects in the reconstruction to understand. Not expected.

@slava77

lgray · 2016-12-11T15:32:22Z

OK - talking to @slava77 a bit more since the beamspot is different the comparison with the baseline is different from the SIM level so it's hard to make a good comparison with 10 events.

lgray · 2016-12-11T16:10:32Z

@VinInn @rovere @mmusich

Just FYI the current reco::BeamSpot parameters for HL-LHC are:

-----------------------------------------------------
              Beam Spot Data

 Beam type    = 2
       X0     = 1.56059e-05 +/- 1.11113e-05 [cm]
       Y0     = -5.14073e-06 +/- 1.08985e-05 [cm]
       Z0     = 0.0282329 +/- 0.0694134 [cm]
 Sigma Z0     = 4.31313 +/- 0.0490817 [cm]
 dxdz         = 0.000103158 +/- 2.53614e-06 [radians]
 dydz         = -2.13911e-07 +/- 2.48033e-06 [radians]
 Beam Width X = 0.00137129 +/- 2.07524e-05 [cm]
 Beam Width Y = 0.000806147 +/- 2.07524e-05 [cm]
 Emittance X  = 0 [cm]
 Emittance Y  = 0 [cm]
 Beta star    = 0 [cm]
-----------------------------------------------------

And for this new HL-LHC beam spot the BeamWidthX is 11um (instead of 13um), BeamWidthY is 5um (instead of 8um), SigmaZ is more or less the same.

Should we update the beamspot, or just go as is?

lgray · 2016-12-11T16:23:24Z

However, the bias in the x0 (which should be zero for HL-LHC) is over one sigma. Not sure if that matters for tracking.

mmusich · 2016-12-11T18:44:51Z

@lgray about:

Should we update the beamspot, or just go as is?

we can easily update it if you point me to the list of preferred parameters.

lgray · 2016-12-11T19:13:45Z

@mmusich Noted! I will await input concerning the need to update from @VinInn and @rovere in that case.

kpedro88 · 2016-12-11T19:25:03Z

unhold

cmsbuild · 2016-12-11T19:25:18Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

davidlange6 · 2016-12-12T08:35:45Z

+1

davidlange6 · 2016-12-12T15:47:00Z

I realize I merged this one prematurely - however the beam spot bias issue is not due to this PR, so I'm not reverting it (unless discussion to come indicates that is the right thing).

lgray · 2016-12-12T16:00:00Z

Beamspot bias issue? Guessing this is for present running or is this for Phase 2 studies?

…

On Mon, Dec 12, 2016 at 4:47 PM, David Lange ***@***.***> wrote: I realize I merged this one prematurely - however the beam spot bias issue is not due to this PR, so I'm not reverting it (unless discussion to come indicates that is the right thing). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#16942 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABBMOYpLgbQZQ462oY2dfStPDWSLuRB8ks5rHWx1gaJpZM4LIxvT> .

lgray · 2016-12-12T16:19:31Z

@davidlange6 I'm curious about this because there are some offsets we see in timing distributions that appeared that we haven't been able to trace down.

…

On Dec 12, 2016 9:59 AM, "Lindsey Gray" ***@***.***> wrote: Beamspot bias issue? Guessing this is for present running or is this for Phase 2 studies? On Mon, Dec 12, 2016 at 4:47 PM, David Lange ***@***.***> wrote: > I realize I merged this one prematurely - however the beam spot bias > issue is not due to this PR, so I'm not reverting it (unless discussion to > come indicates that is the right thing). > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#16942 (comment)>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/ABBMOYpLgbQZQ462oY2dfStPDWSLuRB8ks5rHWx1gaJpZM4LIxvT> > . >

lgray · 2016-12-12T16:20:05Z

Even with the "NoSmear" beamspot.

lgray added 3 commits December 8, 2016 18:45

working on integrating HL-LHC beam parameterization from machine folks

ea05749

work in progress

eed59ba

now reproduces zt distribution of latest HL-LHC beamspot

5f33356

cmsbuild added this to the Next CMSSW_9_0_X milestone Dec 9, 2016

cmsbuild added comparison-pending orp-pending pending-signatures simulation-pending tests-pending labels Dec 9, 2016

cmsbuild added tests-started and removed tests-pending labels Dec 9, 2016

cmsbuild added tests-rejected and removed tests-started labels Dec 9, 2016

use M_PI to define 2pi

2bb5d9d

cmsbuild added tests-pending and removed tests-rejected labels Dec 9, 2016

cmsbuild added tests-started and removed tests-pending labels Dec 9, 2016

cmsbuild added tests-rejected and removed tests-started labels Dec 9, 2016

cmsbuild added hold pending-signatures and removed fully-signed labels Dec 10, 2016

cmsbuild added fully-signed and removed hold pending-signatures labels Dec 11, 2016

cmsbuild added orp-approved and removed orp-pending labels Dec 12, 2016

cmsbuild merged commit 0535d0c into cms-sw:CMSSW_9_0_X Dec 12, 2016

mmusich mentioned this pull request Dec 13, 2016

[90X] update the BeamSpot for the 2023 upgrade simulation #17000

Merged

lgray mentioned this pull request Jan 20, 2017

Complete propagation of precision timing to reconstruction and MiniAOD #17238

Closed

francescobrivio mentioned this pull request Oct 26, 2023

Add SimBeamSpotObjects to MC Global Tags cms-AlCaDB/AlCaTools#86

Closed

8 tasks

This was referenced May 1, 2024

switch to CLHEP/Units/SystemOfUnits to avoid numerous single character symbols in global scope #44882

Merged

possible bug in HLLHCEvtVtxGenerator in RF800 mode #44894

Open

francescobrivio mentioned this pull request Jun 26, 2024

Add new SimBeamSpotHLLHC CondFormat #43186

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

A correct description of the HL-LHC beamspot #16942

A correct description of the HL-LHC beamspot #16942

lgray commented Dec 9, 2016

cmsbuild commented Dec 9, 2016

lgray commented Dec 9, 2016

cmsbuild commented Dec 9, 2016 •

edited

Loading

cmsbuild commented Dec 9, 2016

cmsbuild commented Dec 9, 2016

cmsbuild commented Dec 9, 2016

lgray commented Dec 9, 2016

cmsbuild commented Dec 9, 2016 •

edited

Loading

cmsbuild commented Dec 9, 2016

cmsbuild commented Dec 9, 2016

lgray commented Dec 11, 2016

lgray commented Dec 11, 2016

lgray commented Dec 11, 2016

lgray commented Dec 11, 2016

lgray commented Dec 11, 2016 •

edited

Loading

lgray commented Dec 11, 2016 •

edited

Loading

mmusich commented Dec 11, 2016

lgray commented Dec 11, 2016 •

edited

Loading

kpedro88 commented Dec 11, 2016

cmsbuild commented Dec 11, 2016

davidlange6 commented Dec 12, 2016

davidlange6 commented Dec 12, 2016

lgray commented Dec 12, 2016 via email

lgray commented Dec 12, 2016 via email

lgray commented Dec 12, 2016

A correct description of the HL-LHC beamspot #16942

A correct description of the HL-LHC beamspot #16942

Conversation

lgray commented Dec 9, 2016

cmsbuild commented Dec 9, 2016

lgray commented Dec 9, 2016

cmsbuild commented Dec 9, 2016 • edited Loading

cmsbuild commented Dec 9, 2016

cmsbuild commented Dec 9, 2016

cmsbuild commented Dec 9, 2016

lgray commented Dec 9, 2016

cmsbuild commented Dec 9, 2016 • edited Loading

cmsbuild commented Dec 9, 2016

cmsbuild commented Dec 9, 2016

lgray commented Dec 11, 2016

lgray commented Dec 11, 2016

lgray commented Dec 11, 2016

lgray commented Dec 11, 2016

lgray commented Dec 11, 2016 • edited Loading

lgray commented Dec 11, 2016 • edited Loading

mmusich commented Dec 11, 2016

lgray commented Dec 11, 2016 • edited Loading

kpedro88 commented Dec 11, 2016

cmsbuild commented Dec 11, 2016

davidlange6 commented Dec 12, 2016

davidlange6 commented Dec 12, 2016

lgray commented Dec 12, 2016 via email

lgray commented Dec 12, 2016 via email

lgray commented Dec 12, 2016

cmsbuild commented Dec 9, 2016 •

edited

Loading

cmsbuild commented Dec 9, 2016 •

edited

Loading

lgray commented Dec 11, 2016 •

edited

Loading

lgray commented Dec 11, 2016 •

edited

Loading

lgray commented Dec 11, 2016 •

edited

Loading