-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PixelTracksForL3Isolation configurations and IsolationRegionAroundL3Muon as obsolete #16863
Remove PixelTracksForL3Isolation configurations and IsolationRegionAroundL3Muon as obsolete #16863
Conversation
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_9_0_X. It involves the following packages: RecoMuon/L3MuonIsolationProducer @cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready The workflows 1003.0, 1001.0, 1000.0, 140.53, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
@jhgoh, @calderona, @HuguesBrun, @battibass please confirm that it's OK to remove these muon HLT modules |
Hello @slava77 , |
@HuguesBrun @sarafiorendi @BenjaminRS Thanks for the confirmation, I'll modify the PR title and description accordingly. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
+1 |
While migrating
PixelTrackProducer
to the new seeding framework (from #16635), I encountered*TracksForL3Isolation_cf*.py
set of configuration files andIsolationRegionAroundL3Muon
TrackingRegionProducer
that seem to be currently unused.I'm asking if they are obsolete and can be removed, or still need to be maintained? (I'm more interested in the configs than the region producer).The files were confirmed to be obsolete (see message below #16863 (comment)).The commit shows the exact set of files.
Tested in CMSSW_9_0_X_2016-12-02-1100, no changes expected.
@slava77 @cvuosalo @rovere @VinInn @mtosi