Transform pixel track fitter, filter, and cleaner to ED or ES products

[makortel]

This PR contains intermediate developments before migrating PixelTrackProducer to the new seeding framework of #16635. The point is to make all other components than the hit ntuplet generation to support fillDescriptions(). This is achieved by making fitters and filters EDProducts (because at least one of the algorithms depend on event data) and making cleaners ESProducts (because none of the cleaners need event data).

I have tried to migrate all uses in CMSSW, but I can't exclude of missing something.

The next step is to migrate PixelTrackProducer to the new seeding framework (#16635), and fully migrate HLT (with customizeHLTforCMSSW.py).

Tested in CMSSW_9_0_X_2016-11-27-2300 (rebased on top of CMSSW_9_0_X_2016-12-04-2300), no changes expected.

@rovere @VinInn @felicepantaleo @mtosi @JanFSchulte

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_9_0_X.

It involves the following packages:

Calibration/IsolatedParticles
DQM/BeamMonitor
DQM/Integration
FastSimulation/HighLevelTrigger
FastSimulation/Tracking
HLTrigger/Configuration
RecoHI/HiJetAlgos
RecoHI/HiTracking
RecoMuon/L3MuonProducer
RecoMuon/TrackerSeedGenerator
RecoPixelVertexing/Configuration
RecoPixelVertexing/PixelLowPtUtilities
RecoPixelVertexing/PixelTrackFitting
RecoTracker/Record

@perrotta, @cmsbuild, @civanch, @lveldere, @silviodonato, @cvuosalo, @arunhep, @ssekmen, @mdhildreth, @dmitrijus, @Martin-Grunewald, @franzoni, @ghellwig, @cerminar, @slava77, @fwyzard, @mmusich, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @yslai, @felicepantaleo, @abbiendi, @Martin-Grunewald, @threus, @geoff-smith, @battibass, @jhgoh, @HuguesBrun, @trocino, @yetkinyilmaz, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @tocheng, @jalimena, @mschrode, @dgulhan, @echapon, @batinkov, @mandrenguyen, @jazzitup, @calderona, @yenjie, @kurtejung, @gpetruc, @matt-komm, @rociovilar, @bachtis this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16652/console

[cmsbuild]

-1

Tested at: 7b054b6

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16792/16652/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

• AddOn:

I found errors in the following addon tests:

cmsRun /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2016-11-28-2300/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Nov 29 16:18:12 2016-date Tue Nov 29 16:17:10 2016 s - exit: 23040
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=HeavyIons -n 10 --conditions auto:run2_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Tue Nov 29 16:18:12 2016-date Tue Nov 29 16:17:10 2016 s - exit: 256
cmsRun /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2016-11-28-2300/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Nov 29 16:23:07 2016-date Tue Nov 29 16:17:31 2016 s - exit: 23040
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Tue Nov 29 16:23:07 2016-date Tue Nov 29 16:17:31 2016 s - exit: 256

[cmsbuild]

Comparison job queued.

[makortel]

@cmsbuild, please test

(trivial typo; but are there instructions somewhere how I could run the "AddOn" tests myself?)

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16655/console

[cmsbuild]

Pull request #16792 was updated. @perrotta, @cmsbuild, @civanch, @lveldere, @silviodonato, @cvuosalo, @arunhep, @ssekmen, @mdhildreth, @dmitrijus, @Martin-Grunewald, @franzoni, @ghellwig, @cerminar, @slava77, @fwyzard, @mmusich, @vanbesien, @davidlange6 can you please check and sign again.

[Martin-Grunewald]

addOnTests.py

[slava77]

ping
we need DQM, HLT, AlCa and FastSim signatures here

[Martin-Grunewald]

please test
(HLT menu has changed since in 90X)

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16990/console Started: 2016/12/13 08:52

[cmsbuild]

+1
Tested at: 5e6513c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16792/16990/summary.html

[cmsbuild]

Comparison job queued.

[Martin-Grunewald]

+1

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16792/16990/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• 20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D7_GenSimHLBeamSpotFull14+DigiFull_2023D7+RecoFullGlobal_2023D7+HARVESTFullGlobal_2023D7
• 23234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D8_GenSimHLBeamSpotFull14+DigiFull_2023D8+RecoFullGlobal_2023D8+HARVESTFullGlobal_2023D8

[mmusich]

+1

[makortel]

For the follow-up PR I'll wait until either #17041 or #17042 gets merged (because I have to migrate the customize function, and doing anything there now would just create conflicts).

[fwyzard]

By the way @makortel , which approach do you prefer, #17041 or #17042 ?
I'm trying to figure out with @Martin-Grunewald and @silviodonato which one to choose, feel free to chime in.

[makortel]

@fwyzard I can certainly share my experience from offline tracking, where are you having the discussion?(this PR is likely not the right forum)