Improve early delete configuration in ConfigBuilder #16779
Conversation
|
@slava77 @davidlange6 Something along this? |
|
@cmsbuild, please test |
|
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_9_0_X. It involves the following packages: Configuration/Applications @cmsbuild, @cvuosalo, @franzoni, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
The tests are being triggered in jenkins. |
| self.pythonCfgCode += "# End adding early deletion\n" | ||
| self.pythonCfgCode += "\n# Add early deletion of temporary data products to reduce peak memory need\n" | ||
| self.pythonCfgCode += "from Configuration.StandardSequences.earlyDeleteSettings_cff import customiseEarlyDeleteForRECO\n" | ||
| self.pythonCfgCode += "process = customiseEarlyDeleteForRECO(process)\n" |
There was a problem hiding this comment.
since "if RECO" is removed, it's worth changing this to "customiseEarlyDelete" without "ForRECO"
There was a problem hiding this comment.
Good point. I thought it at some point but (apparently) forgot.
|
Comparison job queued. |
|
Comparison is ready The workflows 1003.0, 1001.0, 1000.0, 140.53, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
As the customize is now applied for all steps.
|
How about now? |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready The workflows 1003.0, 1001.0, 1000.0, 140.53, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons |
|
+1
|
This PR is a follow-up of #16635 addressing the comments about early delete configuration in ConfigBuilder. In addition, I extended the
_hasInputTagModuleLabel()function to check also possiblerefToPSet_'s, and added a unit test for the function.Tested in CMSSW_9_0_X_2016-11-24-2300 by diffing edmConfigDumps of RECO step of limited matrix (also that the limited matrix runs).