Make all registry data members non-mutable #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following categories have been signed by chrjones (a.k.a. @Dr15Jones on GitHub): Core @cms-git-visualization, @cms-git-core, @cms-git-geometry |
| void initializeTransients() {transient_.reset();} | ||
|
|
||
| struct Transients { |
There was a problem hiding this comment.
I assumed this stayed to avoid backwards compatibility problems?
There was a problem hiding this comment.
- Possible backward compatibility problems was one reason.
Other reasons: - Removing it forces tricky changes in classes_def.xml which are non-trivial to get right, if they work at all.
- Future proofing against a subsequent addition of new transient data members.
- Standardization: Keeping it makes it like other registries.
Bill
|
Hi, |
smuzaffar
added a commit
that referenced
this pull request
Jul 24, 2013
Make all registry data members non-mutable
nclopezo
added a commit
to nclopezo/cmssw
that referenced
this pull request
Nov 21, 2014
…-ib-pages Generate a summary json file with the latest IB per release queue
parbol
pushed a commit
to parbol/cmssw
that referenced
this pull request
Mar 5, 2015
fixed dataFormat change 706-->723
thomreis
added a commit
to thomreis/cmssw
that referenced
this pull request
Feb 23, 2016
…_uGMT-dev uGMT developments
mariadalfonso
added a commit
to mariadalfonso/cmssw
that referenced
this pull request
Dec 18, 2017
add plots of Ch-higgs_Pt, add TTBar category classification
cerminar
pushed a commit
to cerminar/cmssw
that referenced
this pull request
Mar 9, 2018
Backport DRNN clustering + ntuple updates
fwyzard
added a commit
to makortel/cmssw
that referenced
this pull request
Sep 13, 2018
Pre-compute few constants that could not be declared constexpr. Reduce temporary buffer size. Reduce the block size of the calls to gpuPixelDoublets::getDoubletsFromHisto() from 256 to 64, to make better usage of the GPU processors.
dsosnov
pushed a commit
to dsosnov/cmssw
that referenced
this pull request
Nov 14, 2018
* Revert "Revert "Fix for trkMVA branch in trackTree" (cms-sw#164)" This reverts commit f793d57. in official AOD: floats_generalTracks_MVAValues_RECO.obj : vector<float>
bi-ran
added a commit
to bi-ran/cmssw
that referenced
this pull request
Jan 24, 2019
* Revert "Revert "Fix for trkMVA branch in trackTree" (cms-sw#164)" This reverts commit f793d57. in official AOD: floats_generalTracks_MVAValues_RECO.obj : vector<float>
slava77
pushed a commit
to slava77/cmssw
that referenced
this pull request
Oct 9, 2021
Candidate ranking à la CMSSW
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is another small step towards the multithreaded framework. It eliminates the last three mutable data members from registries. The Parentage, ProcessConfiguration, and ProcessHistory classes each contained a mutable cached hash id used for storage in a registry. In the case of Parentage, the cached ID is simply removed, because it is not needed. In the case of the other two classes, the cached ID is made non mutable. The "id()" function remains const, because, while it still reads from the cache, it no longer fills the cache. A new "set" function fills the cache when needed.
Also, in the case of Parentage, a non-const function with the same name as a const function is removed and replaced with other functions.
Also, "for" loops affected by this change are changed to C++11 range for loops.
This code has been fully tested with checkdeps -a. All framework unit tests and relval matrix tests pass.