add customization function to switch the pixelTracks for the iterativ…

[JanFSchulte]

…e tracking for PF at HLT to use quadruplets created by the Cellular Automaton and adapts the iterative tracking accordingly. Does not switch any other pixelTrackProducers that are in the menu.

[cmsbuild]

A new Pull Request was created by @JanFSchulte (Jan-Frederik Schulte) for CMSSW_8_1_X.

It involves the following packages:

HLTrigger/Configuration

@perrotta, @cmsbuild, @silviodonato, @Martin-Grunewald, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @geoff-smith, @jalimena this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[silviodonato]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16320/console

[Martin-Grunewald]

This will never work in a robust way!
I see hardwired module labels, and we know we change labels sometimes.
Even worse, I see hardwired HLT path names with version numbers, and those are also changed.
This code requires an enormous maintenance effort for an evolving menu.
We should restrict it to a single menu or make the code better in dealing with developments of the menu itself.

[JanFSchulte]

Well, most of it changes the irerative tracking, which will not be changed without me knowing it, so this is no problem. I agree that the changes to hardcoded sequences is very ugly. If you have a suggestion how to dynamically replace process.hltPixelLayerTriplets with process.hltPixelLayerQuadruplets in sequences, I am happy to make this less dependent on the specific menu.

[fwyzard]

That is definitely possible, and I think we have done it in the past - maybe there are some examples in the other customisation functions. Unfortunately I cannot look them up on my phone :-( Ciao, .Andrea

[cmsbuild]

+1
Tested at: 5ff70cc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16563/16320/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
f62a3c5
c089a11
333f839
05f0fff
ef1bd26
602c6ed
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16563/16320/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16563/16320/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16563/16320/summary.html

[cmsbuild]

Pull request #16563 was updated. @perrotta, @cmsbuild, @silviodonato, @Martin-Grunewald, @fwyzard, @davidlange6 can you please check and sign again.

[cmsbuild]

Pull request #16563 was updated. @perrotta, @cmsbuild, @silviodonato, @Martin-Grunewald, @fwyzard, @davidlange6 can you please check and sign again.

[Martin-Grunewald]

-1
No proliferation of small files. Collect all customisations in a single py file as separate python routines
(to be stichted together on the cmsDriver cmdline).

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16563/16623/summary.html

[cmsbuild]

Pull request #16563 was updated. @perrotta, @cmsbuild, @silviodonato, @Martin-Grunewald, @fwyzard, @davidlange6 can you please check and sign again.

[JanFSchulte]

@Martin-Grunewald @makortel This should adress both of your commets.

[Martin-Grunewald]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16643/console

[cmsbuild]

+1
Tested at: 5a4746f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16563/16643/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16563/16643/summary.html

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

[davidlange6]

+1