-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pixel Geometry Fixes #16519
Pixel Geometry Fixes #16519
Conversation
Subtraction is not needed, width reduced to not conflct with tube
Density adjusted accordingly
A new Pull Request was created by @schneiml (Marcel Schneider) for CMSSW_8_1_X. It involves the following packages: Geometry/TrackerCommonData @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar |
@civanch and @davidlange6 - comparing with previous display the overlaps in Pixel are fixed. |
+1 |
These two commits should fix the Phase1 Pixel geometry issues reported in the Offline week diskussion.
The pixbar volumes touched here were not modified for a long time, and it is not clear why the subtraction was used there in the first place. It seems safe to remove it, but this should be checked again.
We attempted to compensate the material budget changes by adjusting the material densities accordingly, even though the change is probably within the tolerance of these numbers.