Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factorize fast timing layer geometry dependent things from RECO algorithms. #16501

Merged

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Nov 8, 2016

Allows D*Timing Eras to run as well as D5.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2016

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_8_1_X.

It involves the following packages:

Configuration/Eras
Configuration/Geometry
Configuration/PyReleaseValidation
Configuration/StandardSequences
SimGeneral/MixingModule

@civanch, @Dr15Jones, @ianna, @mdhildreth, @fabozzi, @cmsbuild, @srimanob, @franzoni, @hengne, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @wmtan, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dgulhan this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@lgray
Copy link
Contributor Author

lgray commented Nov 8, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16235/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2016

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2016

@Dr15Jones
Copy link
Contributor

+1

@lgray
Copy link
Contributor Author

lgray commented Nov 8, 2016

@slava77 Could you check this PR that everything is OK?

@lgray
Copy link
Contributor Author

lgray commented Nov 8, 2016

@slava77 I at least made sure that all the WFs run now and there are no missing products. Otherwise this should have no physics impact.

@slava77
Copy link
Contributor

slava77 commented Nov 8, 2016

assign reconstruction
... although I think it will not work and someone with right permissions should say that

@lgray
Copy link
Contributor Author

lgray commented Nov 9, 2016

@civanch @fabozzi @srimanob @franzoni @hengne Please review and sign.

@slava77
Copy link
Contributor

slava77 commented Nov 11, 2016

Just to repeat earlier call from Lindsey

@civanch @fabozzi @srimanob @franzoni @hengne Please review and sign.

this is blocking one other PR and is also keeping Timing workflows without the "I2" timing layer broken.

@davidlange6
Copy link
Contributor

changes in sim are trivial - will bypass

@davidlange6 davidlange6 merged commit 350469b into cms-sw:CMSSW_8_1_X Nov 11, 2016
@makortel makortel mentioned this pull request Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants