remove HcalUpgradeDataFrame and related classes/algos #16461

kpedro88 · 2016-11-04T03:37:10Z

The generic HcalUpgradeDataFrame class has now been fully supplanted by QIE10DataFrame and QIE11DataFrame, and is no longer needed. Related classes and algorithms are also no longer needed.

A few minor related changes:

Fix some HGCal tests to use QIE11DataFrame
Make HcalTDC's primary function a template, pending potential renovations for modern use
Remove never-used QIE10 reco algo in HcalSimpleReconstructor

attn: @igv4321, @bsunanda, @lgray, @mdhildreth

cmsbuild · 2016-11-04T03:37:29Z

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_1_X.

It involves the following packages:

CalibFormats/HcalObjects
DataFormats/HcalDigi
RecoLocalCalo/HcalRecAlgos
RecoLocalCalo/HcalRecProducers
SimCalorimetry/HcalSimAlgos
SimCalorimetry/HcalSimProducers
SimCalorimetry/HcalZeroSuppressionProducers
SimGeneral/DataMixingModule
Validation/HGCalValidation

@ghellwig, @civanch, @cvuosalo, @mdhildreth, @dmitrijus, @cmsbuild, @franzoni, @cerminar, @slava77, @mmusich, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @vandreev11, @sethzenz, @wmtan, @tocheng, @lgray, @cseez, @bsunanda, @pfs, @mariadalfonso, @argiro this is something you requested to watch as well.
@slava77, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

kpedro88 · 2016-11-04T03:37:35Z

@cmsbuild please test

cmsbuild · 2016-11-04T03:37:46Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16191/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16192/console

cmsbuild · 2016-11-04T08:27:41Z

-1

Tested at: 821734c

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16461/16192/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals AddOn

Unit Tests:

I found errors in the following unit tests:

---> test testRecoMETMETProducers had ERRORS

RelVals:

When I ran the RelVals I found an error in the following worklfows:
4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

8.0 step2

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step2_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

1306.0 step2

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

10021.0 step2

runTheMatrix-results/10021.0_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step2_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

1330.0 step2

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step2_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

136.731 step3

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

50202.0 step2

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log

9.0 step2

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step2_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

20024.0 step2

runTheMatrix-results/20024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D1_GenSimHLBeamSpotFull+DigiFull_2023D1+RecoFullGlobal_2023D1+HARVESTFullGlobal_2023D1/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D1_GenSimHLBeamSpotFull+DigiFull_2023D1+RecoFullGlobal_2023D1+HARVESTFullGlobal_2023D1.log

25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

10024.0 step2

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

25.0 step2

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step2_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

23224.0 step2

runTheMatrix-results/23224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D5_GenSimHLBeamSpotFull+DigiFull_2023D5+RecoFullGlobal_2023D5+HARVESTFullGlobal_2023D5/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2023D5_GenSimHLBeamSpotFull+DigiFull_2023D5+RecoFullGlobal_2023D5+HARVESTFullGlobal_2023D5.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@Fake,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Fri Nov 4 09:17:58 2016-date Fri Nov 4 09:17:53 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Fri Nov 4 09:27:10 2016-date Fri Nov 4 09:17:57 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=HeavyIons -n 10 --conditions auto:run2_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Fri Nov 4 09:20:21 2016-date Fri Nov 4 09:18:01 2016 s - exit: 256
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_GRun_MC.root : FAILED - time: date Fri Nov 4 09:18:57 2016-date Fri Nov 4 09:18:04 2016 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-11-03-2300/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Nov 4 09:18:57 2016-date Fri Nov 4 09:18:04 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Fri Nov 4 09:18:57 2016-date Fri Nov 4 09:18:04 2016 s - exit: 256
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@relval25ns,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns --magField 38T_PostLS1 : FAILED - time: date Fri Nov 4 09:18:09 2016-date Fri Nov 4 09:18:06 2016 s - exit: 256
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_PRef_MC.root : FAILED - time: date Fri Nov 4 09:18:59 2016-date Fri Nov 4 09:18:09 2016 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-11-03-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Nov 4 09:18:59 2016-date Fri Nov 4 09:18:09 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Fri Nov 4 09:18:59 2016-date Fri Nov 4 09:18:09 2016 s - exit: 256
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,HLT:@relval2016,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 --magField 38T_PostLS1 : FAILED - time: date Fri Nov 4 09:18:14 2016-date Fri Nov 4 09:18:11 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Fri Nov 4 09:23:05 2016-date Fri Nov 4 09:18:13 2016 s - exit: 256
cmsDriver.py TTbar_Tauola_8TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_MC.root : FAILED - time: date Fri Nov 4 09:18:34 2016-date Fri Nov 4 09:18:17 2016 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-11-03-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Nov 4 09:18:34 2016-date Fri Nov 4 09:18:17 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_MC.root --fileout file:RelVal_Raw_Fake_MC_HLT_RECO.root : FAILED - time: date Fri Nov 4 09:18:34 2016-date Fri Nov 4 09:18:17 2016 s - exit: 256
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016,Run2_HI --magField 38T_PostLS1 --fileout file:RelVal_Raw_HIon_MC.root : FAILED - time: date Fri Nov 4 09:19:09 2016-date Fri Nov 4 09:18:20 2016 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-11-03-2300/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Nov 4 09:19:09 2016-date Fri Nov 4 09:18:20 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Fri Nov 4 09:19:09 2016-date Fri Nov 4 09:18:20 2016 s - exit: 256
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_25ns --fileout file:RelVal_Raw_Fake1_MC.root : FAILED - time: date Fri Nov 4 09:18:39 2016-date Fri Nov 4 09:18:22 2016 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-11-03-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake1.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Nov 4 09:18:39 2016-date Fri Nov 4 09:18:22 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_MC.root --fileout file:RelVal_Raw_Fake1_MC_HLT_RECO.root : FAILED - time: date Fri Nov 4 09:18:39 2016-date Fri Nov 4 09:18:22 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run1_data_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_DATA.root --fileout file:RelVal_Raw_Fake_DATA_HLT_RECO.root : FAILED - time: date Fri Nov 4 09:19:04 2016-date Fri Nov 4 09:18:27 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Fri Nov 4 09:21:05 2016-date Fri Nov 4 09:18:32 2016 s - exit: 256
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_DATA.root --fileout file:RelVal_Raw_Fake1_DATA_HLT_RECO.root : FAILED - time: date Fri Nov 4 09:19:10 2016-date Fri Nov 4 09:18:33 2016 s - exit: 256
cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --magField 38T_PostLS1 --fileout file:RelVal_Raw_PIon_MC.root : FAILED - time: date Fri Nov 4 09:19:29 2016-date Fri Nov 4 09:18:38 2016 s - exit: 18688
cmsRun /cvmfs/cms-ib.cern.ch/week1/slc6_amd64_gcc530/cms/cmssw/CMSSW_8_1_X_2016-11-03-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Nov 4 09:19:29 2016-date Fri Nov 4 09:18:38 2016 s - exit: 21504
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Fri Nov 4 09:19:29 2016-date Fri Nov 4 09:18:38 2016 s - exit: 256

cmsbuild · 2016-11-04T08:27:44Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

kpedro88 · 2016-11-04T15:25:27Z

@cmsbuild please test

cmsbuild · 2016-11-04T15:25:32Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16205/console

cmsbuild · 2016-11-04T15:25:33Z

Pull request #16461 was updated. @ghellwig, @civanch, @cvuosalo, @mdhildreth, @dmitrijus, @cmsbuild, @franzoni, @cerminar, @slava77, @mmusich, @vanbesien, @davidlange6 can you please check and sign again.

kpedro88 · 2016-11-04T21:00:23Z

any more review or should I relaunch tests?

slava77 · 2016-11-04T21:06:52Z

On 11/4/16 2:00 PM, Kevin Pedro wrote:

any more review or should I relaunch tests?

nothing else for now

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#16461 (comment), or
mute the thread
https://github.com/notifications/unsubscribe-auth/AEdcblRQfUGv_kZa_N4FJpE2uSUPNTHeks5q65zpgaJpZM4KpKX-.

kpedro88 · 2016-11-04T21:07:45Z

@cmsbuild please test

cmsbuild · 2016-11-04T21:08:03Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/16210/console

cmsbuild · 2016-11-04T22:48:20Z

+1
Tested at: d55e81b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16461/16210/summary.html

cmsbuild · 2016-11-04T22:48:23Z

Comparison job queued.

cmsbuild · 2016-11-04T23:41:47Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-16461/16210/summary.html

dmitrijus · 2016-11-08T12:52:57Z

+1

civanch · 2016-11-08T15:55:35Z

+1

cvuosalo · 2016-11-08T19:26:05Z

+1

For #16461 d55e81b

Phase 1/2 code clean-up -- deleting obsolete classes and minor revisions. There should be no change in monitored quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-11-04-1100 show no significant differences, as expected.

kpedro88 · 2016-11-10T08:40:20Z

@mmusich please sign if acceptable

remove HcalUpgradeDataFrame and related classes/algos

821734c

cmsbuild added this to the Next CMSSW_8_1_X milestone Nov 4, 2016

cmsbuild added alca-pending comparison-pending dqm-pending orp-pending pending-signatures reconstruction-pending simulation-pending tests-pending labels Nov 4, 2016

cmsbuild added tests-started and removed tests-pending labels Nov 4, 2016

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Nov 4, 2016

missed a few removals

e2e45f3

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Nov 4, 2016

cmsbuild removed the tests-pending label Nov 4, 2016

cmsbuild added tests-started and removed tests-pending labels Nov 4, 2016

cmsbuild added tests-approved and removed tests-started labels Nov 4, 2016

cmsbuild added comparison-available and removed comparison-pending labels Nov 4, 2016

cmsbuild added dqm-approved and removed dqm-pending labels Nov 8, 2016

cmsbuild added simulation-approved and removed simulation-pending labels Nov 8, 2016

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Nov 8, 2016

davidlange6 merged commit 4dd522f into cms-sw:CMSSW_8_1_X Nov 11, 2016

kpedro88 mentioned this pull request Nov 11, 2016

[81X] Add Phase-I Cosmics #16343

Merged

mmusich added a commit to cms-AlCaDB/cmssw that referenced this pull request Nov 16, 2016

changes needed to compile correctly: cms-sw#16461

eebeb44

mmusich added a commit to cms-AlCaDB/cmssw that referenced this pull request Nov 21, 2016

changes needed to compile correctly: cms-sw#16461

76e944c

mmusich added a commit to cms-AlCaDB/cmssw that referenced this pull request Nov 21, 2016

changes needed to compile correctly: cms-sw#16461

80083ea

mmusich added a commit to cms-AlCaDB/cmssw that referenced this pull request Nov 21, 2016

changes needed to compile correctly: cms-sw#16461

9cbe0a2

mmusich added a commit to cms-AlCaDB/cmssw that referenced this pull request Nov 22, 2016

changes needed to compile correctly: cms-sw#16461

7674182

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove HcalUpgradeDataFrame and related classes/algos #16461

remove HcalUpgradeDataFrame and related classes/algos #16461

kpedro88 commented Nov 4, 2016

cmsbuild commented Nov 4, 2016

kpedro88 commented Nov 4, 2016

cmsbuild commented Nov 4, 2016 •

edited

Loading

cmsbuild commented Nov 4, 2016

cmsbuild commented Nov 4, 2016

kpedro88 commented Nov 4, 2016

cmsbuild commented Nov 4, 2016 •

edited

Loading

cmsbuild commented Nov 4, 2016

kpedro88 commented Nov 4, 2016

slava77 commented Nov 4, 2016

kpedro88 commented Nov 4, 2016

cmsbuild commented Nov 4, 2016 •

edited

Loading

cmsbuild commented Nov 4, 2016

cmsbuild commented Nov 4, 2016

cmsbuild commented Nov 4, 2016

dmitrijus commented Nov 8, 2016

civanch commented Nov 8, 2016

cvuosalo commented Nov 8, 2016

kpedro88 commented Nov 10, 2016

remove HcalUpgradeDataFrame and related classes/algos #16461

remove HcalUpgradeDataFrame and related classes/algos #16461

Conversation

kpedro88 commented Nov 4, 2016

cmsbuild commented Nov 4, 2016

kpedro88 commented Nov 4, 2016

cmsbuild commented Nov 4, 2016 • edited Loading

cmsbuild commented Nov 4, 2016

cmsbuild commented Nov 4, 2016

kpedro88 commented Nov 4, 2016

cmsbuild commented Nov 4, 2016 • edited Loading

cmsbuild commented Nov 4, 2016

kpedro88 commented Nov 4, 2016

slava77 commented Nov 4, 2016

kpedro88 commented Nov 4, 2016

cmsbuild commented Nov 4, 2016 • edited Loading

cmsbuild commented Nov 4, 2016

cmsbuild commented Nov 4, 2016

cmsbuild commented Nov 4, 2016

dmitrijus commented Nov 8, 2016

civanch commented Nov 8, 2016

cvuosalo commented Nov 8, 2016

kpedro88 commented Nov 10, 2016

cmsbuild commented Nov 4, 2016 •

edited

Loading

cmsbuild commented Nov 4, 2016 •

edited

Loading

cmsbuild commented Nov 4, 2016 •

edited

Loading