Improve efficiency of trigTools::setFiltersObjPasses #15051
Conversation
The function was creating a edm::InputTag, converting that to a string then passing the string to a function which needs an edm::InputTag so the compiler created yet another edm::InputTag. Now the code just directly passes the edm::InputTag to the function. This code was brought to my attention because running this code using multiple threads has periodically crashed at this line of code. The problem is not understood and it is unlikely that this change fixes the underlying problem.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_1_X. It involves the following packages: DQMOffline/Trigger @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
+1 |
The function was creating a edm::InputTag, converting that to a string
then passing the string to a function which needs an edm::InputTag so
the compiler created yet another edm::InputTag. Now the code just
directly passes the edm::InputTag to the function.
This code was brought to my attention because running this code
using multiple threads has periodically crashed at this line of code.
The problem is not understood and it is unlikely that this change
fixes the underlying problem.