Remove obsolete customiseForRunI

[makortel]

With the introduction of trackingLowPU sub-era in #13988 the old (currently non-functional) customiseForRunI became obsolete. This PR removes all files related to customiseForRunI as well as all uses of those files. There were couple of places where a simple removal of the use was clearly not correct behaviour. Those places throw now an exception asking to use trackingLowPU (they would anyway need some refurbishing to get them to working state).

Tested in CMSSW_8_1_X_2016-04-24-0000, no changes expected in standard workflows.

@rovere @VinInn @slava77

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_1_X.

It involves the following packages:

Configuration/DataProcessing
RecoLocalMuon/GEMRecHit
RecoLocalTracker/SubCollectionProducers
RecoTracker/Configuration
RecoTracker/IterativeTracking
SLHCUpgradeSimulations/Configuration

@civanch, @cvuosalo, @mdhildreth, @cmsbuild, @franzoni, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald, @forthommel, @yduhm, @GiacomoSguazzoni, @gbenelli, @jhgoh, @VinInn, @nickmccoll, @bellan, @jlagram, @mschrode, @rovere, @cerati, @gpetruc, @OlivierBondu, @threus, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12663/console

[cmsbuild]

-1

Tested at: 81464ae

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14267/12663/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test TestConfigDP had ERRORS

[makortel]

I was a bit afraid of that failure (and was surprised that I didn't observe it in my local tests first, I can reproduce it now though).

@slava77 Please advise what to do. Naively I would think to replace "ppRun2B0T" with "ppEra_Run2_2016_trackingLowPU" in https://github.com/cms-sw/cmssw/blob/CMSSW_8_1_X/Configuration/DataProcessing/test/run_CfgTest.sh. Which reminds me, is the DataProcessing part of #13945 (introducing "ppEra_Run2_2016_trackingLowPU" scenario) already in 81X?

[slava77]

@makortel
the DataProcessing was not updated yet
So, this PR will have to wait (can be a few days).
If this cleanup is urgent, I can suggest you edit run_CfgTest.sh and remove ppRun2B0T

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14267/12663/summary.html

[makortel]

@slava77 It's not urgent. I just got reminded of these while grepping something else and I thought to do the cleanup now so that eventually the obsolete stuff would get away (from my greps).

[slava77]

#14350 was just merged
It triggered conflicts due to overlapping changes in RecoTLR.
@makortel please rebase.

[makortel]

@slava77 IIUC it should be enough that I drop the changes in RecoTLR from this PR, right? (I'm trying to avoid waiting for the next IB, i.e. essentially until Monday in this case)

[slava77]

@makortel
if all the conflicts are with #14350, then yes, just drop RecoTLR changes.
This will probably not need a rebase then.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12825/console

[slava77]

uhm, I guess I asked for the jenkins test too early. It will not include #14350 yet and the DP unit test will still fail

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12834/console

[cmsbuild]

+1
Tested at: a003f68
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14267/12834/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14267/12834/summary.html

[slava77]

+1

for #14267 a003f68

• code changes are as described
• jenkins tests pass and comparisons with baseline show no differences

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1