Remove mutable keyword by removing const declaration from unused functio... #1415
Conversation
|
A new Pull Request was created by @wmtan for CMSSW_7_0_X. Remove mutable keyword by removing const declaration from unused functio... It involves the following packages: SimDataFormats/HiGenData @cmsbuild, @civanch, @nclopezo, @mdhildreth, @giamman can you please review it and eventually sign? Thanks. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
| const std::vector<reco::GenParticleRef> getSubEvent(unsigned int sub_id) const; | ||
|
|
||
| int getNsubs() const {return subevents_.size();} | ||
|
|
||
| private: | ||
|
|
||
| mutable SubEventCollection subevents_; |
There was a problem hiding this comment.
This does not change the checksum of the class, right?
There was a problem hiding this comment.
Unfortunately, that variable is stored. However, I'm pretty sure ROOT has no idea about 'mutable' so this won't change the checksum. If it did, scram would complain.
There was a problem hiding this comment.
Removing the mutable keyword does not change the check sum of the class. This was tested experimentally.
There was a problem hiding this comment.
Just checking…;) Merging this.
Multithreading fixes -- Remove mutable keyword by removing const declaration from unused function
Eliminate static analyzer warning about thread safety by removing the mutable keyword from a data member of
GenHIEvent and removing the const qualifier from the declaration of the function that modifies it.
The function in question was added three years ago and is never called anywhere in CMSSW, so this is clearly harmless.