fix getByLabelWithoutRegistration #13041
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @jingyucms (Jingyu Zhang) for CMSSW_7_6_X. It involves the following packages: GeneratorInterface/GenFilters @vciulli, @civanch, @covarell, @mdhildreth, @cmsbuild, @thuer, @bendavid, @davidlange6, @govoni can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
| @@ -219,6 +219,7 @@ namespace edm { | |||
| std::vector<std::string> digiNames = digiPSet.getParameterNames(); | |||
| for(auto const& digiName : digiNames) { | |||
| ParameterSet const& pset = digiPSet.getParameterSet(digiName); | |||
| consumes<HepMCProduct>(pset.getParameter<edm::InputTag>("HepMCProductLabel")); | |||
There was a problem hiding this comment.
@jingyucms - i'm not sure why this line is here. If its needed, it should be outside the loop
|
@jingyucms -please make a 80x version of this. |
|
-1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I run MixingModule and GetByLabelWithoutRegistration fault [1]. This shouldn't be general fix. This is just my fix that solve my problem. Appreciated if expert have a solution.
[1]
----- Begin Fatal Exception 19-Jan-2016 14:45:08 CET-----------------------
An exception of category 'GetByLabelWithoutRegistration' occurred while
[0] Processing run: 1 lumi: 87451 event: 14604151
[1] Running path 'HLT_MuFilterTP_v1'
[2] Calling event method for module MixingModule/'mix'
Exception Message:
::getByLabel without corresponding call to consumes or mayConsumes for this module.
type: edm::HepMCProduct
module label: generatorSmeared
product instance name: ''
process name: ''
----- End Fatal Exception -------------------------------------------------