Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of existsAs in (some) tracking code #12966

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Jan 15, 2016

this PR is mainly meant for getting rid of some existsAs in the tracking code
towards 2016 confDB template in 80x

a customization function for HLT (back-compatibility) is also provided
hopefully w/ all relevant modules and proper setting

I realized that there was a typo in 2 modules
=> I have corrected it as well (MaxDispacement --> MaxDisplacement)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_8_0_X.

It involves the following packages:

HLTrigger/Configuration
RecoEgamma/EgammaElectronProducers
RecoEgamma/EgammaPhotonProducers
RecoTracker/MeasurementDet
RecoTracker/TkTrackingRegions
TrackingTools/GsfTracking
TrackingTools/KalmanUpdators
TrackingTools/TrajectoryFiltering

@perrotta, @cmsbuild, @cvuosalo, @slava77, @Martin-Grunewald, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Sam-Harper, @geoff-smith, @battibass, @makortel, @abbiendi, @GiacomoSguazzoni, @cerati, @rovere, @VinInn, @Martin-Grunewald, @bellan, @jhgoh, @jalimena, @istaslis, @mschrode, @gpetruc, @lgray, @trocino, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@slava77
Copy link
Contributor

slava77 commented Jan 15, 2016

Mia,
please post a message when you are done with commits on your side

@cvuosalo
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10556/console

@cmsbuild
Copy link
Contributor

-1
Tested at: 46737ad
When I ran the RelVals I found an error in the following worklfows:
134.911 step2

runTheMatrix-results/134.911_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2_25nsreHLT/step2_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2_25nsreHLT.log
----- Begin Fatal Exception 15-Jan-2016 21:00:53 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CkfTrajectoryMaker label='hltL3TrackCandidateFromL2OIState'
Exception Message:
MissingParameter: Parameter 'strictSeedExtension' not found.
----- End Fatal Exception -------------------------------------------------

140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log
----- Begin Fatal Exception 15-Jan-2016 21:01:38 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=PixelTrackProducer label='hiPixel3PrimTracks'
Exception Message:
MissingParameter: Parameter 'useMultipleScattering' not found.
----- End Fatal Exception -------------------------------------------------

1306.0 step2

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 15-Jan-2016 21:03:26 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CkfTrajectoryMaker label='hltL3TrackCandidateFromL2OIState'
Exception Message:
MissingParameter: Parameter 'strictSeedExtension' not found.
----- End Fatal Exception -------------------------------------------------

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log
----- Begin Fatal Exception 15-Jan-2016 21:05:04 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CkfTrackCandidateMaker label='hltMu8Ele8CkfTrackCandidateMaker'
Exception Message:
MissingParameter: Parameter 'strictSeedExtension' not found.
----- End Fatal Exception -------------------------------------------------

1330.0 step2

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step2_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 15-Jan-2016 21:07:47 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CkfTrajectoryMaker label='hltL3TrackCandidateFromL2OIState'
Exception Message:
MissingParameter: Parameter 'strictSeedExtension' not found.
----- End Fatal Exception -------------------------------------------------

25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
----- Begin Fatal Exception 15-Jan-2016 21:16:56 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CkfTrajectoryMaker label='hltL3TrackCandidateFromL2OIState'
Exception Message:
MissingParameter: Parameter 'strictSeedExtension' not found.
----- End Fatal Exception -------------------------------------------------

50202.0 step2

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
----- Begin Fatal Exception 15-Jan-2016 21:17:23 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=CkfTrajectoryMaker label='hltL3TrackCandidateFromL2OIState'
Exception Message:
MissingParameter: Parameter 'strictSeedExtension' not found.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12966/10556/summary.html

@Martin-Grunewald
Copy link
Contributor

Hi,

If the fillDescription is done properly, one does not need all those entries in the customize for HLT file,
as fillDescription will take care to insert in case the parameter is missing in the py file.

@Martin-Grunewald
Copy link
Contributor

This PR must be delayed until after #12816 is integrated, at which point you likely have to re-edit the customisation file.

@cmsbuild
Copy link
Contributor

Pull request #12966 was updated. @perrotta, @cmsbuild, @cvuosalo, @slava77, @Martin-Grunewald, @fwyzard, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #12966 was updated. @perrotta, @cmsbuild, @cvuosalo, @slava77, @Martin-Grunewald, @fwyzard, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #12966 was updated. @perrotta, @cmsbuild, @cvuosalo, @slava77, @Martin-Grunewald, @fwyzard, @davidlange6 can you please check and sign again.

@mtosi
Copy link
Contributor Author

mtosi commented Jan 18, 2016

also RecoTracker/ConversionSeedGenerators/python/ConversionStep_cff.py needed to be updated (sorry, I missed it in previous commits)
now, it should be fixed

I do not understand why 140.53 is still failing, though
I explicitly checked it in my working area
and it worked after my commit on the HI packages

@VinInn
Copy link
Contributor

VinInn commented Jan 18, 2016

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10574/console

@VinInn
Copy link
Contributor

VinInn commented Jan 18, 2016

@mtosi, previous test results was for Tested at: 21b0489 , before your latest commit
I suspect next round of tests will still miss the last fix

@cmsbuild
Copy link
Contributor

-1
Tested at: edfb84d
When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log
----- Begin Fatal Exception 18-Jan-2016 15:49:56 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of ESProducer or ESSource of type Chi2ChargeMeasurementEstimatorESProducer with label: 'convStepChi2Est'
Exception Message:
Illegal parameter found in configuration.  The parameter is named:
 'MaxDispacement'
You could be trying to use a parameter name that is not
allowed for this plugin or it could be misspelled.
----- End Fatal Exception -------------------------------------------------

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log
----- Begin Fatal Exception 18-Jan-2016 15:57:47 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of ESProducer or ESSource of type Chi2ChargeMeasurementEstimatorESProducer with label: 'convStepChi2Est'
Exception Message:
Illegal parameter found in configuration.  The parameter is named:
 'MaxDispacement'
You could be trying to use a parameter name that is not
allowed for this plugin or it could be misspelled.
----- End Fatal Exception -------------------------------------------------

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log
----- Begin Fatal Exception 18-Jan-2016 15:57:47 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of ESProducer or ESSource of type Chi2ChargeMeasurementEstimatorESProducer with label: 'convStepChi2Est'
Exception Message:
Illegal parameter found in configuration.  The parameter is named:
 'MaxDispacement'
You could be trying to use a parameter name that is not
allowed for this plugin or it could be misspelled.
----- End Fatal Exception -------------------------------------------------

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log
----- Begin Fatal Exception 18-Jan-2016 15:59:40 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of ESProducer or ESSource of type Chi2ChargeMeasurementEstimatorESProducer with label: 'convStepChi2Est'
Exception Message:
Illegal parameter found in configuration.  The parameter is named:
 'MaxDispacement'
You could be trying to use a parameter name that is not
allowed for this plugin or it could be misspelled.
----- End Fatal Exception -------------------------------------------------

134.911 step3

runTheMatrix-results/134.911_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2_25nsreHLT/step3_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2_25nsreHLT.log
----- Begin Fatal Exception 18-Jan-2016 15:59:40 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of ESProducer or ESSource of type Chi2ChargeMeasurementEstimatorESProducer with label: 'convStepChi2Est'
Exception Message:
Illegal parameter found in configuration.  The parameter is named:
 'MaxDispacement'
You could be trying to use a parameter name that is not
allowed for this plugin or it could be misspelled.
----- End Fatal Exception -------------------------------------------------

101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log
----- Begin Fatal Exception 18-Jan-2016 16:00:12 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of ESProducer or ESSource of type Chi2ChargeMeasurementEstimatorESProducer with label: 'convStepChi2Est'
Exception Message:
Illegal parameter found in configuration.  The parameter is named:
 'MaxDispacement'
You could be trying to use a parameter name that is not
allowed for this plugin or it could be misspelled.
----- End Fatal Exception -------------------------------------------------

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 18-Jan-2016 16:04:54 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of ESProducer or ESSource of type Chi2ChargeMeasurementEstimatorESProducer with label: 'convStepChi2Est'
Exception Message:
Illegal parameter found in configuration.  The parameter is named:
 'MaxDispacement'
You could be trying to use a parameter name that is not
allowed for this plugin or it could be misspelled.
----- End Fatal Exception -------------------------------------------------

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log
----- Begin Fatal Exception 18-Jan-2016 16:07:49 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of ESProducer or ESSource of type Chi2ChargeMeasurementEstimatorESProducer with label: 'convStepChi2Est'
Exception Message:
Illegal parameter found in configuration.  The parameter is named:
 'MaxDispacement'
You could be trying to use a parameter name that is not
allowed for this plugin or it could be misspelled.
----- End Fatal Exception -------------------------------------------------

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 18-Jan-2016 16:08:05 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of ESProducer or ESSource of type Chi2ChargeMeasurementEstimatorESProducer with label: 'convStepChi2Est'
Exception Message:
Illegal parameter found in configuration.  The parameter is named:
 'MaxDispacement'
You could be trying to use a parameter name that is not
allowed for this plugin or it could be misspelled.
----- End Fatal Exception -------------------------------------------------

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4.log
----- Begin Fatal Exception 18-Jan-2016 16:08:39 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of ESProducer or ESSource of type Chi2ChargeMeasurementEstimatorESProducer with label: 'convStepChi2Est'
Exception Message:
Illegal parameter found in configuration.  The parameter is named:
 'MaxDispacement'
You could be trying to use a parameter name that is not
allowed for this plugin or it could be misspelled.
----- End Fatal Exception -------------------------------------------------

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log
----- Begin Fatal Exception 18-Jan-2016 16:09:30 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of ESProducer or ESSource of type Chi2ChargeMeasurementEstimatorESProducer with label: 'convStepChi2Est'
Exception Message:
Illegal parameter found in configuration.  The parameter is named:
 'MaxDispacement'
You could be trying to use a parameter name that is not
allowed for this plugin or it could be misspelled.
----- End Fatal Exception -------------------------------------------------

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
----- Begin Fatal Exception 18-Jan-2016 16:23:57 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of ESProducer or ESSource of type Chi2ChargeMeasurementEstimatorESProducer with label: 'convStepChi2Est'
Exception Message:
Illegal parameter found in configuration.  The parameter is named:
 'MaxDispacement'
You could be trying to use a parameter name that is not
allowed for this plugin or it could be misspelled.
----- End Fatal Exception -------------------------------------------------

50202.0 step3

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
----- Begin Fatal Exception 18-Jan-2016 16:24:13 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of ESProducer or ESSource of type Chi2ChargeMeasurementEstimatorESProducer with label: 'convStepChi2Est'
Exception Message:
Illegal parameter found in configuration.  The parameter is named:
 'MaxDispacement'
You could be trying to use a parameter name that is not
allowed for this plugin or it could be misspelled.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12966/10573/summary.html

@mtosi
Copy link
Contributor Author

mtosi commented Jan 18, 2016

last reported crash should be fixed by mtosi@6ee1ef5
(sorry for the many commits)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@mtosi
Copy link
Contributor Author

mtosi commented Jan 20, 2016

is it possible to test, please ?
thanks much

@VinInn
Copy link
Contributor

VinInn commented Jan 20, 2016

@mtosi, it is successfully tested tested at 6ee1ef5

@Martin-Grunewald
Copy link
Contributor

Newly added file HLTrigger/Configuration/python/customizeHLTfor2016trackingTemplate.py
does not seem to be used in this PR. Why is it needed?

@cvuosalo
Copy link
Contributor

@mtosi: The Jenkins DQM comparison shows about 2000 HLT-related tiny differences for workflow 50202.0_TTbar_13. From the description of this PR, I would not expect any differences to be generated. Could you please add to the PR description an explanation of what changes to event content and Reco quantities should be expected from this PR?

@Martin-Grunewald
Copy link
Contributor

@mtosi

  1. please comment on my question above concerning the unused file
  2. now that Revision of HLT for 80X/2016 #12816 is merged, you need to resolve the merge conflicts in this PR
    (most likely resulting from customizeHLTforCMSSW.py which is changed in both PRs)

@fwyzard
Copy link
Contributor

fwyzard commented Jan 21, 2016 via email

@Martin-Grunewald
Copy link
Contributor

Hmm, this would need instructions to be posted somewhere (tk wiki?) for the POGs to pickup on!

@slava77
Copy link
Contributor

slava77 commented Jan 25, 2016

-1
superseded by 13062

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants