-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get rid of existsAs in (some) tracking code #12966
get rid of existsAs in (some) tracking code #12966
Conversation
A new Pull Request was created by @mtosi (mia tosi) for CMSSW_8_0_X. It involves the following packages: HLTrigger/Configuration @perrotta, @cmsbuild, @cvuosalo, @slava77, @Martin-Grunewald, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
Mia, |
@cmsbuild please test |
The tests are being triggered in jenkins. |
-1 runTheMatrix-results/134.911_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2_25nsreHLT/step2_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2_25nsreHLT.log ----- Begin Fatal Exception 15-Jan-2016 21:00:53 CET----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=CkfTrajectoryMaker label='hltL3TrackCandidateFromL2OIState' Exception Message: MissingParameter: Parameter 'strictSeedExtension' not found. ----- End Fatal Exception ------------------------------------------------- 140.53 step2 runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log ----- Begin Fatal Exception 15-Jan-2016 21:01:38 CET----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=PixelTrackProducer label='hiPixel3PrimTracks' Exception Message: MissingParameter: Parameter 'useMultipleScattering' not found. ----- End Fatal Exception ------------------------------------------------- 1306.0 step2 runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log ----- Begin Fatal Exception 15-Jan-2016 21:03:26 CET----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=CkfTrajectoryMaker label='hltL3TrackCandidateFromL2OIState' Exception Message: MissingParameter: Parameter 'strictSeedExtension' not found. ----- End Fatal Exception ------------------------------------------------- 135.4 step1 runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log ----- Begin Fatal Exception 15-Jan-2016 21:05:04 CET----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=CkfTrackCandidateMaker label='hltMu8Ele8CkfTrackCandidateMaker' Exception Message: MissingParameter: Parameter 'strictSeedExtension' not found. ----- End Fatal Exception ------------------------------------------------- 1330.0 step2 runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step2_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log ----- Begin Fatal Exception 15-Jan-2016 21:07:47 CET----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=CkfTrajectoryMaker label='hltL3TrackCandidateFromL2OIState' Exception Message: MissingParameter: Parameter 'strictSeedExtension' not found. ----- End Fatal Exception ------------------------------------------------- 25202.0 step2 runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log ----- Begin Fatal Exception 15-Jan-2016 21:16:56 CET----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=CkfTrajectoryMaker label='hltL3TrackCandidateFromL2OIState' Exception Message: MissingParameter: Parameter 'strictSeedExtension' not found. ----- End Fatal Exception ------------------------------------------------- 50202.0 step2 runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log ----- Begin Fatal Exception 15-Jan-2016 21:17:23 CET----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Constructing module: class=CkfTrajectoryMaker label='hltL3TrackCandidateFromL2OIState' Exception Message: MissingParameter: Parameter 'strictSeedExtension' not found. ----- End Fatal Exception ------------------------------------------------- you can see the results of the tests here: |
Hi, If the fillDescription is done properly, one does not need all those entries in the customize for HLT file, |
This PR must be delayed until after #12816 is integrated, at which point you likely have to re-edit the customisation file. |
Pull request #12966 was updated. @perrotta, @cmsbuild, @cvuosalo, @slava77, @Martin-Grunewald, @fwyzard, @davidlange6 can you please check and sign again. |
Pull request #12966 was updated. @perrotta, @cmsbuild, @cvuosalo, @slava77, @Martin-Grunewald, @fwyzard, @davidlange6 can you please check and sign again. |
Pull request #12966 was updated. @perrotta, @cmsbuild, @cvuosalo, @slava77, @Martin-Grunewald, @fwyzard, @davidlange6 can you please check and sign again. |
also RecoTracker/ConversionSeedGenerators/python/ConversionStep_cff.py needed to be updated (sorry, I missed it in previous commits) I do not understand why 140.53 is still failing, though |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
-1 runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log ----- Begin Fatal Exception 18-Jan-2016 15:49:56 CET----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Validating configuration of ESProducer or ESSource of type Chi2ChargeMeasurementEstimatorESProducer with label: 'convStepChi2Est' Exception Message: Illegal parameter found in configuration. The parameter is named: 'MaxDispacement' You could be trying to use a parameter name that is not allowed for this plugin or it could be misspelled. ----- End Fatal Exception ------------------------------------------------- 9.0 step3 runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log ----- Begin Fatal Exception 18-Jan-2016 15:57:47 CET----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Validating configuration of ESProducer or ESSource of type Chi2ChargeMeasurementEstimatorESProducer with label: 'convStepChi2Est' Exception Message: Illegal parameter found in configuration. The parameter is named: 'MaxDispacement' You could be trying to use a parameter name that is not allowed for this plugin or it could be misspelled. ----- End Fatal Exception ------------------------------------------------- 135.4 step1 runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log ----- Begin Fatal Exception 18-Jan-2016 15:57:47 CET----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Validating configuration of ESProducer or ESSource of type Chi2ChargeMeasurementEstimatorESProducer with label: 'convStepChi2Est' Exception Message: Illegal parameter found in configuration. The parameter is named: 'MaxDispacement' You could be trying to use a parameter name that is not allowed for this plugin or it could be misspelled. ----- End Fatal Exception ------------------------------------------------- 25.0 step3 runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log ----- Begin Fatal Exception 18-Jan-2016 15:59:40 CET----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Validating configuration of ESProducer or ESSource of type Chi2ChargeMeasurementEstimatorESProducer with label: 'convStepChi2Est' Exception Message: Illegal parameter found in configuration. The parameter is named: 'MaxDispacement' You could be trying to use a parameter name that is not allowed for this plugin or it could be misspelled. ----- End Fatal Exception ------------------------------------------------- 134.911 step3 runTheMatrix-results/134.911_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2_25nsreHLT/step3_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2_25nsreHLT.log ----- Begin Fatal Exception 18-Jan-2016 15:59:40 CET----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Validating configuration of ESProducer or ESSource of type Chi2ChargeMeasurementEstimatorESProducer with label: 'convStepChi2Est' Exception Message: Illegal parameter found in configuration. The parameter is named: 'MaxDispacement' You could be trying to use a parameter name that is not allowed for this plugin or it could be misspelled. ----- End Fatal Exception ------------------------------------------------- 101.0 step1 runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log ----- Begin Fatal Exception 18-Jan-2016 16:00:12 CET----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Validating configuration of ESProducer or ESSource of type Chi2ChargeMeasurementEstimatorESProducer with label: 'convStepChi2Est' Exception Message: Illegal parameter found in configuration. The parameter is named: 'MaxDispacement' You could be trying to use a parameter name that is not allowed for this plugin or it could be misspelled. ----- End Fatal Exception ------------------------------------------------- 1306.0 step3 runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log ----- Begin Fatal Exception 18-Jan-2016 16:04:54 CET----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Validating configuration of ESProducer or ESSource of type Chi2ChargeMeasurementEstimatorESProducer with label: 'convStepChi2Est' Exception Message: Illegal parameter found in configuration. The parameter is named: 'MaxDispacement' You could be trying to use a parameter name that is not allowed for this plugin or it could be misspelled. ----- End Fatal Exception ------------------------------------------------- 1000.0 step2 runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log ----- Begin Fatal Exception 18-Jan-2016 16:07:49 CET----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Validating configuration of ESProducer or ESSource of type Chi2ChargeMeasurementEstimatorESProducer with label: 'convStepChi2Est' Exception Message: Illegal parameter found in configuration. The parameter is named: 'MaxDispacement' You could be trying to use a parameter name that is not allowed for this plugin or it could be misspelled. ----- End Fatal Exception ------------------------------------------------- 1330.0 step3 runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log ----- Begin Fatal Exception 18-Jan-2016 16:08:05 CET----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Validating configuration of ESProducer or ESSource of type Chi2ChargeMeasurementEstimatorESProducer with label: 'convStepChi2Est' Exception Message: Illegal parameter found in configuration. The parameter is named: 'MaxDispacement' You could be trying to use a parameter name that is not allowed for this plugin or it could be misspelled. ----- End Fatal Exception ------------------------------------------------- 1001.0 step2 runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4.log ----- Begin Fatal Exception 18-Jan-2016 16:08:39 CET----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Validating configuration of ESProducer or ESSource of type Chi2ChargeMeasurementEstimatorESProducer with label: 'convStepChi2Est' Exception Message: Illegal parameter found in configuration. The parameter is named: 'MaxDispacement' You could be trying to use a parameter name that is not allowed for this plugin or it could be misspelled. ----- End Fatal Exception ------------------------------------------------- 1003.0 step2 runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log ----- Begin Fatal Exception 18-Jan-2016 16:09:30 CET----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Validating configuration of ESProducer or ESSource of type Chi2ChargeMeasurementEstimatorESProducer with label: 'convStepChi2Est' Exception Message: Illegal parameter found in configuration. The parameter is named: 'MaxDispacement' You could be trying to use a parameter name that is not allowed for this plugin or it could be misspelled. ----- End Fatal Exception ------------------------------------------------- 25202.0 step3 runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log ----- Begin Fatal Exception 18-Jan-2016 16:23:57 CET----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Validating configuration of ESProducer or ESSource of type Chi2ChargeMeasurementEstimatorESProducer with label: 'convStepChi2Est' Exception Message: Illegal parameter found in configuration. The parameter is named: 'MaxDispacement' You could be trying to use a parameter name that is not allowed for this plugin or it could be misspelled. ----- End Fatal Exception ------------------------------------------------- 50202.0 step3 runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log ----- Begin Fatal Exception 18-Jan-2016 16:24:13 CET----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Validating configuration of ESProducer or ESSource of type Chi2ChargeMeasurementEstimatorESProducer with label: 'convStepChi2Est' Exception Message: Illegal parameter found in configuration. The parameter is named: 'MaxDispacement' You could be trying to use a parameter name that is not allowed for this plugin or it could be misspelled. ----- End Fatal Exception ------------------------------------------------- you can see the results of the tests here: |
last reported crash should be fixed by mtosi@6ee1ef5 |
is it possible to test, please ? |
Newly added file |
@mtosi: The Jenkins DQM comparison shows about 2000 HLT-related tiny differences for workflow 50202.0_TTbar_13. From the description of this PR, I would not expect any differences to be generated. Could you please add to the PR description an explanation of what changes to event content and Reco quantities should be expected from this PR? |
|
As far as I know,
`HLTrigger/Configuration/python/customizeHLTfor2016trackingTemplate.py` is
available to implement a 2016-like confguration, but is not picked up by
default.
It may be useful for POGs to check the new configuration before the actual
migration in ConfDB (if we decide to do it), but strictly speaking is not
necessary.
|
Hmm, this would need instructions to be posted somewhere (tk wiki?) for the POGs to pickup on! |
-1 |
this PR is mainly meant for getting rid of some existsAs in the tracking code
towards 2016 confDB template in 80x
a customization function for HLT (back-compatibility) is also provided
hopefully w/ all relevant modules and proper setting
I realized that there was a typo in 2 modules
=> I have corrected it as well (MaxDispacement --> MaxDisplacement)