Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run2-hcx62 Validation toolket for HGCAL #12857

Merged
merged 1 commit into from
Jan 25, 2016

Conversation

bsunanda
Copy link
Contributor

This PR can be tested only when #12845 is integrated. It uses many of the new functionalities there

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for CMSSW_8_0_X.

It involves the following packages:

Validation/HGCalValidation

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @kpedro88, @lgray, @cseez, @pfs this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@lgray
Copy link
Contributor

lgray commented Jan 11, 2016

@cmsbuild please test

Dependencies are now in CMSSW.

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10457/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

if (nameDetector_ == "HGCalEESensitive") {
//HGCalEE
edm::Handle<HGCEEDigiCollection> theHGCEEDigiContainers;
iEvent.getByLabel(digiSource_, theHGCEEDigiContainers);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be migrated to consumes

@lgray
Copy link
Contributor

lgray commented Jan 20, 2016

@deguio let me know when you're done reviewing and I'll address your comments, and open a new PR since Sunanda is away.

@deguio
Copy link
Contributor

deguio commented Jan 20, 2016

ciao @lgray
I think this one can go in once the consumes migration is addressed. this PR has been reviewed back in Oct/Nov (see #11872).
for reference, here the details presented and discussed at the DQM meeting:
https://indico.cern.ch/event/453276/contribution/3/attachments/1169232/1687152/Phase2-Talk22.pdf

ciao and thanks,
F.

@lgray
Copy link
Contributor

lgray commented Jan 20, 2016

OK -- it is added to the stack. Need to find a stopping point in trying to debug hex geometry.

@lgray
Copy link
Contributor

lgray commented Jan 24, 2016

-1 I will open a new PR for this with the requested changed momentarily.

@lgray
Copy link
Contributor

lgray commented Jan 24, 2016

@davidlange6 please close this PR. Thanks!

@deguio
Copy link
Contributor

deguio commented Jan 25, 2016

-1
superseded by #13046

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@lgray
Copy link
Contributor

lgray commented Jan 25, 2016

@deguio wrong place for the +1 :)

@deguio
Copy link
Contributor

deguio commented Jan 25, 2016

-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants