-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run2-hcx62 Validation toolket for HGCAL #12857
Conversation
A new Pull Request was created by @bsunanda for CMSSW_8_0_X. It involves the following packages: Validation/HGCalValidation @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
@cmsbuild please test Dependencies are now in CMSSW. |
The tests are being triggered in jenkins. |
if (nameDetector_ == "HGCalEESensitive") { | ||
//HGCalEE | ||
edm::Handle<HGCEEDigiCollection> theHGCEEDigiContainers; | ||
iEvent.getByLabel(digiSource_, theHGCEEDigiContainers); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to be migrated to consumes
@deguio let me know when you're done reviewing and I'll address your comments, and open a new PR since Sunanda is away. |
ciao @lgray ciao and thanks, |
OK -- it is added to the stack. Need to find a stopping point in trying to debug hex geometry. |
-1 I will open a new PR for this with the requested changed momentarily. |
@davidlange6 please close this PR. Thanks! |
-1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
@deguio wrong place for the +1 :) |
-1 |
This PR can be tested only when #12845 is integrated. It uses many of the new functionalities there