Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete cms* scripts 80X #12783

Merged

Conversation

ghellwig
Copy link

This PR removes the usage of the following scripts in the alignment workflows:

cmsLs
cmsMkdir
cmsRm
cmsRmdir
cmsPfn
cmsStage
cmsStageIn
cmsStageOut

These will stop working in January 2016 [1] and have been replaced by supported alternatives.

Added also a commit to copy over a monitoring file for the MillePedeAlgorithm.

[1] https://hypernews.cern.ch/HyperNews/CMS/get/cmpAnnounce/1031.html

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ghellwig (Gregor Mittag) for CMSSW_8_0_X.

It involves the following packages:

Alignment/APEEstimation
Alignment/MillePedeAlignmentAlgorithm
Alignment/OfflineValidation

@diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@mschrode, @mmusich, @tlampen this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@ghellwig
Copy link
Author

Forgot to add a commit. Will reopen after this branch has been updated.

@ghellwig ghellwig closed this Dec 15, 2015
@ghellwig ghellwig reopened this Dec 15, 2015
@cmsbuild
Copy link
Contributor

Pull request #12783 was updated. @diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Dec 15, 2015

@ghellwig is this mature enough for testing?

@ghellwig
Copy link
Author

Yes, it is. The request for the last commit came in rather late and I wanted to avoid another PR just for this trivial change in a file that has anyway to be modified.

@mmusich
Copy link
Contributor

mmusich commented Dec 15, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10300/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor

mmusich commented Dec 15, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Dec 16, 2015
@cmsbuild cmsbuild merged commit c31e053 into cms-sw:CMSSW_8_0_X Dec 16, 2015
@ghellwig ghellwig deleted the remove-obsolete-cms-scripts_80X branch December 16, 2015 09:22
cmsbuild added a commit that referenced this pull request Jan 5, 2016
Remove obsolete cms* scripts 75X (Backport of #12783)
cmsbuild added a commit that referenced this pull request Jan 6, 2016
Remove obsolete cms* scripts 76X( Backport of #12783)
cmsbuild added a commit that referenced this pull request Jan 7, 2016
Remove obsolete cms scripts 74X (Backport of #12783, except APEEstimation package)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants