Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure StreamerInputSource throws an error (75x) #12562

Merged
merged 1 commit into from
Nov 30, 2015

Conversation

dmitrijus
Copy link
Contributor

... and fix DQMStreamerReader to catch that error.

(foward port of #12564)

... and fix DQMStreamerReader to catch that error.
@dmitrijus dmitrijus changed the title Make sure StreamerInputSource throws an error. Make sure StreamerInputSource throws an error (75x) Nov 25, 2015
@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Nov 25, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_7_5_X.

It involves the following packages:

DQMServices/StreamerIO
IOPool/Streamer

@smuzaffar, @Dr15Jones, @danduggan, @cmsbuild, @deguio, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@barvic, @wddgit, @wmtan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@deguio
Copy link
Contributor

deguio commented Nov 25, 2015

please test

@deguio
Copy link
Contributor

deguio commented Nov 25, 2015

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9948/console

@cmsbuild
Copy link
Contributor

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12562/9948/summary.html

@slava77 there are some missing matrix maps:

  • 1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@slava77
Copy link
Contributor

slava77 commented Nov 27, 2015

Is this change already tested/patched online?
Is the fix essential now during HI data taking?

@slava77
Copy link
Contributor

slava77 commented Nov 30, 2015

merge

cmsbuild added a commit that referenced this pull request Nov 30, 2015
Make sure StreamerInputSource throws an error (75x)
@cmsbuild cmsbuild merged commit 836ac96 into cms-sw:CMSSW_7_5_X Nov 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants