Add 2 new GenFilters for use by HI photon team #12511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add HINEcalGenEvtSelector, based on pyquen version (cherry picked from commit c88da8c)
|
A new Pull Request was created by @richard-cms (R. Alex Barbieri) for CMSSW_7_6_X. It involves the following packages: GeneratorInterface/GenFilters @vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @davidlange6, @govoni can you please review it and eventually sign? Thanks. Following commands in first line of a comment are recognized
|
|
I don't think this is needed for 76x. |
|
@bendavid Yeah I think as long it ends up in 80X and 75X I'm happy. |
…g filters (cherry picked from commit 5292924)
|
-1 |
|
Pull request #12511 was updated. @cmsbuild, @davidlange6 can you please check and sign again. |
|
Okay, not needed for 76X, will close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #12510
These two gen filters for Pythia8 are meant to mimic the older ones used with Pyquen, which can be found here:
https://github.com/cms-sw/cmssw/blob/CMSSW_7_5_X/GeneratorInterface/HiGenCommon/src/EcalGenEvtSelector.cc
https://github.com/cms-sw/cmssw/blob/CMSSW_7_5_X/GeneratorInterface/HiGenCommon/src/EcalGenEvtSelectorFrag.cc
@bi-ran has done some sanity checking between the old filters and new filters which can be found here:
https://twiki.cern.ch/twiki/pub/CMS/MITHIGAnalysis2015/MCFilters.pdf
We would like to include these filters in the 75X series to be used for HI MC production.