Apply a "boundary condition" at the outermost pseudorapidity edges

[yslai]

Same bugfix as #12463 for 7_5_X. This bugfix fixes very large (but not infinite) areas that stretches outside the HF by surrounding the event with "mirror events". This is to prevent rare instances, where FastJet would cluster negative pT particles over large distances, and a large, negative particle become a jet in the opposite direction.

Also, the printf() have been converted to EDM log messages.

No performance difference is expected, except for jets either at |eta| ~ 5, or rare events that previously would have contained unreasonably large jet pTs (e.g. 10 TeV).

[cmsbuild]

A new Pull Request was created by @yslai for CMSSW_7_5_X.

It involves the following packages:

RecoHI/HiJetAlgos

@cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@jazzitup, @dgulhan, @yenjie, @kurtejung, @istaslis, @mandrenguyen, @richard-cms, @yetkinyilmaz this is something you requested to watch as well.
@Degano you are the release manager for this.

Following commands in first line of a comment are recognized

• +1|approve[d]|sign[ed]: L1/L2's to approve it
• -1|reject[ed]: L1/L2's to reject it
• assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
• unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
• hold: L1/all L2's/release manager to mark it as on hold
• unhold: L1/user who put this PR on hold
• merge: L1/release managers to merge this request
• [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
• [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9788/console

[cmsbuild]

+1
Tested at: fae31bc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12464/9788/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12464/9788/summary.html

[slava77]

@yslai @mandrenguyen
is this PR essential for HI data taking?

[mandrenguyen]

@slava77
From what I understand it is necessary
@yslai
should comment

[yetkinyilmaz]

on behalf of @yslai, yes, it is necessary.

On 18/11/15 20:21, mandrenguyen wrote:

@slava77 https://github.com/slava77
From what I understand it is necessary
@yslai https://github.com/yslai
should comment

—
Reply to this email directly or view it on GitHub
#12464 (comment).

[cvuosalo]

+1

For #12464 fae31bc

Fix for Heavy Ions jets at the outermost pseudorapidity edges to prevent clustering of negative pT particles over large distances.

The code changes are satisfactory. Jenkins tests against baseline CMSSW_7_5_X_2015-11-16-2300 show the expected differences in jets with |eta| around 5 and the elimination of jets with negative pT of large magnitude in the comparisons for workflow 140.53_RunHI2011, as seen in the following plots.

Jets with eta = ~5 removed in the next two plots:

Note in the following two plots the reduction of Mean and RMS to more reasonable values:

Removal of large negative pT values:

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[slava77]

merge