Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix event display config generation and problem also affecting T0 in config builder #12453

Merged
merged 1 commit into from
Nov 18, 2015

Conversation

deguio
Copy link
Contributor

@deguio deguio commented Nov 17, 2015

basically the addCustomise was adding modules after the repacked <--> fedrawdata collection replace
the EvD config runs fine now on test HI data.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @deguio (Federico De Guio) for CMSSW_7_5_X.

It involves the following packages:

Configuration/Applications
Configuration/DataProcessing

@cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@Degano you are the release manager for this.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request
  • [@cmsbuild,] please test: L1/L2 and selected users to start jenkins tests
  • [@cmsbuild,] please test with cms-sw/cmsdist#<PR>: L1/L2 and selected users to start jenkins tests using externals from cmsdist

@deguio
Copy link
Contributor Author

deguio commented Nov 17, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9770/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Nov 17, 2015

Just a note from my side that the changes in DP code look as expected.

@slava77
Copy link
Contributor

slava77 commented Nov 18, 2015

merge

cmsbuild added a commit that referenced this pull request Nov 18, 2015
fix event display config generation and problem also affecting T0 in config builder
@cmsbuild cmsbuild merged commit ab600e5 into cms-sw:CMSSW_7_5_X Nov 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants