Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for testHGCalLocalReco script #12347

Merged
merged 1 commit into from
Nov 11, 2015

Conversation

vandreev11
Copy link
Contributor

@lgray @pfs @kpedro88 @sethzenz fix for a swap of FH-BH digi collections in the testHGCalLocalReco script.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vandreev11 for CMSSW_8_0_X.

fix for testHGCalLocalReco script

It involves the following packages:

RecoLocalCalo/HGCalRecProducers

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@cseez, @sethzenz, @pfs, @kpedro88, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' 'please test with cms-sw/cmsdist#PR' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@lgray
Copy link
Contributor

lgray commented Nov 10, 2015

@cmsbuild please test

@vandreev11 Thanks for the catch!

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9618/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Nov 11, 2015

+1

for #12347 0d4eca4

  • a pretty clear bugfix; the fixed test file is used in unit tests; doesn't affect standard relval workflows.
  • jenkins tests pass (compiles and the unit test job passes)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Nov 11, 2015
@cmsbuild cmsbuild merged commit b8d060b into cms-sw:CMSSW_8_0_X Nov 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants