Fix temporaries in the header #12322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have to make this as `static` or `extern` in order to keep the
lifetime of these arrays until application terminates. `static` needs to
be picked if values will not be compared by reference between various
translation units otherwise we need `extern`.
Should resolve valgrind detected issues, e.g.:
==27582== Invalid read of size 4
==27582== at 0x5BFEE2D: __gnu_cxx::__exchange_and_add(int volatile*, int) (in /afs/cern.ch/cms/sw/ReleaseCandidates/volB/slc6_amd64_gcc493/external/gcc/4.9.3/lib64/libstdc++.so.6.0.20)
==27582== by 0x5BFEEC1: __gnu_cxx::__exchange_and_add_dispatch(int*, int) (in /afs/cern.ch/cms/sw/ReleaseCandidates/volB/slc6_amd64_gcc493/external/gcc/4.9.3/lib64/libstdc++.so.6.0.20)
==27582== by 0x5C0330F: std::string::_Rep::_M_dispose(std::allocator<char> const&) (in /afs/cern.ch/cms/sw/ReleaseCandidates/volB/slc6_amd64_gcc493/external/gcc/4.9.3/lib64/libstdc++.so.6.0.20)
==27582== by 0x5BFF9E2: std::basic_string<char, std::char_traits<char>, std::allocator<char> >::~basic_string() (in /afs/cern.ch/cms/sw/ReleaseCandidates/volB/slc6_amd64_gcc493/external/gcc/4.9.3/lib64/libstdc++.so.6.0.20)
==27582== by 0x71AD3EF: __tcf_2 (GEMDetLabel.h:4)
==27582== by 0x3A46635B21: exit (in /lib64/libc-2.12.so)
==27582== by 0x3A4661ED63: (below main) (in /lib64/libc-2.12.so)
==27582== Address 0x60579c0 is 16 bytes inside a block of size 30 free'd
==27582== at 0x40290B3: operator delete(void*) (in /afs/cern.ch/cms/sw/ReleaseCandidates/volB/slc6_amd64_gcc493/external/valgrind/3.10.1/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==27582== by 0x5C03D3F: __gnu_cxx::new_allocator<char>::deallocate(char*, unsigned long) (in /afs/cern.ch/cms/sw/ReleaseCandidates/volB/slc6_amd64_gcc493/external/gcc/4.9.3/lib64/libstdc++.so.6.0.20)
==27582== by 0x5C0337E: std::string::_Rep::_M_destroy(std::allocator<char> const&) (in /afs/cern.ch/cms/sw/ReleaseCandidates/volB/slc6_amd64_gcc493/external/gcc/4.9.3/lib64/libstdc++.so.6.0.20)
==27582== by 0x5C0332B: std::string::_Rep::_M_dispose(std::allocator<char> const&) (in /afs/cern.ch/cms/sw/ReleaseCandidates/volB/slc6_amd64_gcc493/external/gcc/4.9.3/lib64/libstdc++.so.6.0.20)
==27582== by 0x5BFF9E2: std::basic_string<char, std::char_traits<char>, std::allocator<char> >::~basic_string() (in /afs/cern.ch/cms/sw/ReleaseCandidates/volB/slc6_amd64_gcc493/external/gcc/4.9.3/lib64/libstdc++.so.6.0.20)
==27582== by 0x713F6FE: __tcf_2 (GEMDetLabel.h:4)
==27582== by 0x3A46635B21: exit (in /lib64/libc-2.12.so)
==27582== by 0x3A4661ED63: (below main) (in /lib64/libc-2.12.so)
Signed-off-by: David Abdurachmanov <[email protected]>
|
All issues below. Pick between |
|
Should resolve issues introduced by #11891 |
|
A new Pull Request was created by @davidlt for CMSSW_8_0_X. Fix temporaries in the header It involves the following packages: Validation/MuonGEMHits @cmsbuild, @danduggan, @vanbesien, @deguio can you please review it and eventually sign? Thanks. |
|
This seems to be: https://sft.its.cern.ch/jira/browse/ROOT-7775 This is needed for ROOT 6.04/6.06 where CMSSW IBs hangs while running
|
davidlange6
added a commit
that referenced
this pull request
Nov 10, 2015
Fix temporaries in the header
davidlt
pushed a commit
to cms-sw/cmsdist
that referenced
this pull request
Nov 24, 2015
ROOT commit: bcfd9aa063d0881063cec712ccbc9e66e443375a Includes a fix for ROOT-7775 (static variable handling). This was causing segfaults in CMSSW (edmConfigWriter). Signal handler inside ROOT was causing deadlock in malloc hanging CMSSW IBs. The following patch was applied in CMSSW to work around the isue: cms-sw/cmssw#12322 Signed-off-by: David Abdurachmanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to make this as
staticorexternin order to keep thelifetime of these arrays until application terminates.
staticneeds tobe picked if values will not be compared by reference between various
translation units otherwise we need
extern.Should resolve valgrind detected issues, e.g.:
Signed-off-by: David Abdurachmanov [email protected]