Fix systematic misalignment tool #12313
Conversation
|
A new Pull Request was created by @hroskes (Heshy Roskes) for CMSSW_8_0_X. Fix systematic misalignment tool It involves the following packages: Alignment/TrackerAlignment @cmsbuild, @mmusich, @diguida, @franzoni, @cerminar can you please review it and eventually sign? Thanks. |
|
please test |
|
The tests are being triggered in jenkins. |
| poolDbService->writeOne<Alignments>(&(*myAlignments), poolDbService->beginOfTime(), theAlignRecordName); | ||
| poolDbService->writeOne<AlignmentErrorsExtended>(&(*myAlignmentErrorsExtended), poolDbService->beginOfTime(), theErrorRecordName); | ||
| } |
There was a problem hiding this comment.
@hroskes what is the reason to remove the possibility to write the APEs? I think it might still be useful even if it's not directly used.
There was a problem hiding this comment.
I didn't really see the use case. All it did was take the APEs from the GT (or input sqlite file if you want) and copy them to the output sqlite file. What would it even mean to "misalign" the APEs?
If you think it would be useful I can add it back.
I'd like to extend this soon by adding misalignment for surface deformations, but I want to understand them better first.
There was a problem hiding this comment.
The use case is exactly this: take the APEs from the GT (or input sqlite file if you want) and copy them to the output sqlite file. Indeed it doesn't make sense to misalign the APE, but creating an APE payload that matches the misalignment you create makes a lot of sense to me. This functionality is not available but costs little effort to implement.
cmsbuild
added
tests-pending
comparison-pending
and removed
comparison-available
tests-approved
labels
|
please test |
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
+1 |
Fix systematic misalignment tool
Backport of #12313: fix systematic misalignment tool
Backport of #12313: fix systematic misalignment tool
Backport of #12313: fix systematic misalignment tool
Fix the test script which hasn't been working for a while, and simplify its use