Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload calogeometry for every event: #12305

Merged
merged 1 commit into from
Nov 10, 2015
Merged

Conversation

lathomas
Copy link
Contributor

@lathomas lathomas commented Nov 7, 2015

geo object seems to change its memory address between runs, leading to segmentation fault from time to time, the change should hopefully fix this.

Apologies for again another iteration related to the CSCHaloFilter...

…emory address between runs, leading to segmentation fault from time to time, the change should hopefully fix this
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2015

A new Pull Request was created by @lathomas for CMSSW_7_6_X.

Reload calogeometry for every event:

It involves the following packages:

RecoMET/METAlgorithms

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @ahinzmann, @mmarionncern, @jdolen, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Nov 9, 2015

@cmsbuild please test
[looks like a clear bugfix]

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9550/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2015

@slava77
Copy link
Contributor

slava77 commented Nov 10, 2015

+1

for #12305 cc46553

  • changes are consistent with the PR description
  • jenkins tests pass and comparisons with baseline show no differences.
  • local test show that the CPU increase is tiny (within jitter, actually): CSCHaloData time in 134.803 (2015C doubleMu) goes up from 5.04 ms to 5.12 ms per event.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Nov 10, 2015
Reload calogeometry for every event:
@cmsbuild cmsbuild merged commit fb488f2 into cms-sw:CMSSW_7_6_X Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants