-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in caching of surface deformations. #12280
Fix bug in caching of surface deformations. #12280
Conversation
This bug has an effect if the DetUnits of a large tracker structure are not listed at all. The net effect of this fix is that omitting them leaves them and the associated surface deformations unchanged.
A new Pull Request was created by @ghellwig (Gregor Mittag) for CMSSW_8_0_X. Fix bug in caching of surface deformations. It involves the following packages: Alignment/CommonAlignment @cmsbuild, @mmusich, @diguida, @franzoni, @cerminar can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
…ng_for_non-alignables_80X Fix bug in caching of surface deformations.
This bug has an effect if the DetUnits of a large tracker structure
that are not listed at all. The net effect of this fix is that omitting
them leaves them and the associated surface deformations unchanged.
This serious bug is discussed in https://indico.cern.ch/event/442138/session/0/contribution/21/attachments/1182456/1712522/talk.pdf