Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the way the folder is handled in SiPixelHLT #12240

Closed

Conversation

hdelanno
Copy link
Contributor

@hdelanno hdelanno commented Nov 3, 2015

This will take back the Pixel line in the summary map for FEDTest

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2015

A new Pull Request was created by @hdelanno (Hugo Delannoy) for CMSSW_7_4_X.

Fix the way the folder is handled in SiPixelHLT

It involves the following packages:

DQM/SiPixelMonitorRawData

@cmsbuild, @danduggan, @vanbesien, @deguio can you please review it and eventually sign? Thanks.
@threus this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' or '@cmsbuild, please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

vanbesien added a commit to vanbesien/cmssw that referenced this pull request Nov 9, 2015
More than 6 years ago the work was started to replace FED by something
new. This was done by placing a second configuration next to FED, called
FEDTest and instruction the shifters (already in 2009) to look at
FEDTest instead of FED. In the meanwhile FED was completely broken and
FEDTest was partly broken. FEDTest was now fixed in cms-sw#12240.
We placed the contents of FEDTest into FED so that this can be the main
default plot to look at again. We should stop running FEDTest in the
near future and adapt the instructions at that moment.
deguio pushed a commit to deguio/cmssw that referenced this pull request Nov 10, 2015
More than 6 years ago the work was started to replace FED by something
new. This was done by placing a second configuration next to FED, called
FEDTest and instruction the shifters (already in 2009) to look at
FEDTest instead of FED. In the meanwhile FED was completely broken and
FEDTest was partly broken. FEDTest was now fixed in cms-sw#12240.
We placed the contents of FEDTest into FED so that this can be the main
default plot to look at again. We should stop running FEDTest in the
near future and adapt the instructions at that moment.
vanbesien added a commit to vanbesien/cmssw that referenced this pull request Nov 10, 2015
More than 6 years ago the work was started to replace FED by something
new. This was done by placing a second configuration next to FED, called
FEDTest and instruction the shifters (already in 2009) to look at
FEDTest instead of FED. In the meanwhile FED was completely broken and
FEDTest was partly broken. FEDTest was now fixed in cms-sw#12240.
We placed the contents of FEDTest into FED so that this can be the main
default plot to look at again. We should stop running FEDTest in the
near future and adapt the instructions at that moment.
vanbesien added a commit to vanbesien/cmssw that referenced this pull request Nov 10, 2015
More than 6 years ago the work was started to replace FED by something
new. This was done by placing a second configuration next to FED, called
FEDTest and instruction the shifters (already in 2009) to look at
FEDTest instead of FED. In the meanwhile FED was completely broken and
FEDTest was partly broken. FEDTest was now fixed in cms-sw#12240.
We placed the contents of FEDTest into FED so that this can be the main
default plot to look at again. We should stop running FEDTest in the
near future and adapt the instructions at that moment.
@deguio
Copy link
Contributor

deguio commented Nov 10, 2015

please submit to 75, 76, 80
thanks,
F.

davidlange6 pushed a commit that referenced this pull request Nov 11, 2015
More than 6 years ago the work was started to replace FED by something
new. This was done by placing a second configuration next to FED, called
FEDTest and instruction the shifters (already in 2009) to look at
FEDTest instead of FED. In the meanwhile FED was completely broken and
FEDTest was partly broken. FEDTest was now fixed in #12240.
We placed the contents of FEDTest into FED so that this can be the main
default plot to look at again. We should stop running FEDTest in the
near future and adapt the instructions at that moment.
@hdelanno
Copy link
Contributor Author

Done, sorry for the delay.

@vanbesien
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9736/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@vanbesien
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants