DataFormats/TrackerRecHit2D: clean Clang override warnings #12162
Conversation
13 Clang warnings popup while building `DataFormats/TrackerRecHit2D`
dictionary with ROOT 6.04 and above. Example:
warning: 'recHits' overrides a member function but is not marked
'override' [-Winconsistent-missing-override]
The patch cleans all 13 warnings.
Signed-off-by: David Abdurachmanov <[email protected]>
|
A new Pull Request was created by @davidlt for CMSSW_8_0_X. DataFormats/TrackerRecHit2D: clean Clang override warnings It involves the following packages: DataFormats/TrackerRecHit2D @cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
+1 Fixing compile-time Clang warnings about missing "override" directives. There should be no change in run-time behavior. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_0_X_2015-10-28-1100 show no problems. Jenkins included several other PRs in the tests, and they produce differences unrelated to this PR. |
cmsbuild
added
reconstruction-approved
fully-signed
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
+1 |
DataFormats/TrackerRecHit2D: clean Clang override warnings
13 Clang warnings popup while building
DataFormats/TrackerRecHit2Ddictionary with ROOT 6.04 and above. Example:
The patch cleans all 13 warnings.
Signed-off-by: David Abdurachmanov [email protected]