fillDescriptions migration and parameter cleanup in DAQ modules (75X) #12146

smorovic · 2015-10-28T16:24:47Z

Changes:

Migrating production DAQ modules EvFDaqDirector, EvFOutputModule, FedRawDataInputSource and FastMonitoringService to using fillDescriptions. Removing cfi python files for those cases.
Removing obsolete parameters from those modules
Allow FastMonitoringService to find definition file in both CMSSW_BASE and CMSSW_RELEASE_BASE (those differ when running from project area).

Update: another two changes were pushed (PR was anyway not signed yet):

FedRawDataInputSource also checks in CMSSW_BASE and CMSSW_RELEASE_BASE for input JSON definition file
Disabling optimization for Exception generator, as the loop in test 9 is otherwise optimised out
(updated also in 76X and 80X PRs)

*ShmStreamConsumer as legacy name remains defined in ShmStreamConsumer_cfi.py

…LEASE_BASE and local path). Parameters for this definition are no longer exported. *file prefixes for fast and slow monitoring do not need to be configurable

cmsbuild · 2015-10-28T16:26:17Z

A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_7_5_X.

fillDescriptions migration and parameter cleanup in DAQ modules (75X)

It involves the following packages:

EventFilter/Utilities

@mommsen, @cvuosalo, @cmsbuild, @emeschi, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

slava77 · 2015-10-28T16:28:14Z

@cmsbuild please test

cmsbuild · 2015-10-28T16:31:20Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9268/console

cmsbuild · 2015-10-28T19:05:14Z

+1
Tested at: f3d03d7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12146/9268/summary.html

cmsbuild · 2015-10-28T19:53:45Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12146/9268/summary.html

9 test to not be optimized out)

…f the former is not found

cmsbuild · 2015-10-30T11:01:37Z

Pull request #12146 was updated. @mommsen, @cvuosalo, @cmsbuild, @emeschi, @slava77 can you please check and sign again.

mommsen · 2015-10-30T11:05:16Z

+1

cmsbuild · 2015-10-30T12:53:39Z

-1

Tested at: b0cc638
I found errors in the following addon tests:

cmsDriver.py TTbar_Tauola_13TeV_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --customise SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1 --magField 38T_PostLS1 --fileout file:RelVal_Raw_GRun_MC.root : FAILED - time: date Fri Oct 30 13:36:00 2015-date Fri Oct 30 13:25:32 2015 s - exit: 16640
cmsRun /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw-patch/CMSSW_7_5_X_2015-10-29-2300/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Fri Oct 30 13:36:00 2015-date Fri Oct 30 13:25:32 2015 s - exit: 21504
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --customise=SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Fri Oct 30 13:36:00 2015-date Fri Oct 30 13:25:32 2015 s - exit: 21504
cmsRun /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc491/cms/cmssw-patch/CMSSW_7_5_X_2015-10-29-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Oct 30 13:36:46 2015-date Fri Oct 30 13:35:41 2015 s - exit: 22016
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --customise=SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Fri Oct 30 13:36:46 2015-date Fri Oct 30 13:35:41 2015 s - exit: 256

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12146/9376/summary.html

cvuosalo · 2015-10-30T16:45:59Z

@cmsbuild please test
Try tests again in hopes they will not land on machine that is out of disk space.

cmsbuild · 2015-10-30T16:46:27Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9396/console
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9397/console

cmsbuild · 2015-10-30T17:14:00Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12146/9376/summary.html

cmsbuild · 2015-10-30T19:00:05Z

+1
Tested at: b0cc638
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12146/9397/summary.html

cmsbuild · 2015-10-30T19:57:09Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12146/9397/summary.html

cvuosalo · 2015-10-30T20:10:43Z

+1

For #12146 b0cc638

fillDescriptions migration in DAQ modules.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-10-30-1100 show no significant differences.

cmsbuild · 2015-10-30T20:12:04Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 · 2015-11-05T15:13:52Z

+1

fillDescriptions migration and parameter cleanup in DAQ modules (75X)

smorovic added 2 commits October 28, 2015 14:41

*converting to fillDescriptions, equivalent EvF cfi files are removed

df5663b

*ShmStreamConsumer as legacy name remains defined in ShmStreamConsumer_cfi.py

*more extensive search for microstate JSON definition (CMSSW_BASE, RE…

f3d03d7

…LEASE_BASE and local path). Parameters for this definition are no longer exported. *file prefixes for fast and slow monitoring do not need to be configurable

smorovic mentioned this pull request Oct 28, 2015

fillDescriptions migration and parameter cleanup in DAQ modules (76X) #12147

Closed

cmsbuild added this to the Next CMSSW_7_5_X milestone Oct 28, 2015

cmsbuild added reconstruction-pending daq-pending pending-signatures tests-pending orp-pending comparison-pending labels Oct 28, 2015

smorovic mentioned this pull request Oct 28, 2015

fillDescriptions migration and parameter cleanup in DAQ modules (80X) #12148

Merged

cmsbuild added tests-started and removed tests-pending labels Oct 28, 2015

cmsbuild added tests-approved and removed tests-started labels Oct 28, 2015

cmsbuild added comparison-available and removed comparison-pending labels Oct 28, 2015

smorovic added 2 commits October 30, 2015 11:28

*disable optimization of test module (allows unused loop result in case

a3a55e1

9 test to not be optimized out)

*looking for input definition file in project area, or release base i…

b0cc638

…f the former is not found

cmsbuild added tests-pending comparison-pending and removed comparison-available tests-approved labels Oct 30, 2015

cmsbuild added tests-started and removed tests-pending labels Oct 30, 2015

cmsbuild added tests-rejected and removed tests-started labels Oct 30, 2015

cmsbuild added tests-pending tests-started and removed tests-rejected tests-pending labels Oct 30, 2015

cmsbuild added comparison-available and removed comparison-pending labels Oct 30, 2015

cmsbuild added tests-approved and removed tests-started labels Oct 30, 2015

cmsbuild added reconstruction-approved fully-signed and removed pending-signatures reconstruction-pending labels Oct 30, 2015

cmsbuild added orp-approved and removed orp-pending labels Nov 5, 2015

cmsbuild added a commit that referenced this pull request Nov 5, 2015

Merge pull request #12146 from smorovic/fillDescriptions-75X

d1d1c3f

fillDescriptions migration and parameter cleanup in DAQ modules (75X)

cmsbuild merged commit d1d1c3f into cms-sw:CMSSW_7_5_X Nov 5, 2015

smorovic deleted the fillDescriptions-75X branch November 13, 2015 10:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fillDescriptions migration and parameter cleanup in DAQ modules (75X) #12146

fillDescriptions migration and parameter cleanup in DAQ modules (75X) #12146

smorovic commented Oct 28, 2015

cmsbuild commented Oct 28, 2015

slava77 commented Oct 28, 2015

cmsbuild commented Oct 28, 2015

cmsbuild commented Oct 28, 2015

cmsbuild commented Oct 28, 2015

cmsbuild commented Oct 30, 2015

mommsen commented Oct 30, 2015

cmsbuild commented Oct 30, 2015

cvuosalo commented Oct 30, 2015

cmsbuild commented Oct 30, 2015

cmsbuild commented Oct 30, 2015

cmsbuild commented Oct 30, 2015

cmsbuild commented Oct 30, 2015

cvuosalo commented Oct 30, 2015

cmsbuild commented Oct 30, 2015

davidlange6 commented Nov 5, 2015

fillDescriptions migration and parameter cleanup in DAQ modules (75X) #12146

fillDescriptions migration and parameter cleanup in DAQ modules (75X) #12146

Conversation

smorovic commented Oct 28, 2015

cmsbuild commented Oct 28, 2015

slava77 commented Oct 28, 2015

cmsbuild commented Oct 28, 2015

cmsbuild commented Oct 28, 2015

cmsbuild commented Oct 28, 2015

cmsbuild commented Oct 30, 2015

mommsen commented Oct 30, 2015

cmsbuild commented Oct 30, 2015

cvuosalo commented Oct 30, 2015

cmsbuild commented Oct 30, 2015

cmsbuild commented Oct 30, 2015

cmsbuild commented Oct 30, 2015

cmsbuild commented Oct 30, 2015

cvuosalo commented Oct 30, 2015

cmsbuild commented Oct 30, 2015

davidlange6 commented Nov 5, 2015