Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring JSON changes in DAQ (80X) #12138

Closed
wants to merge 19 commits into from

Conversation

smorovic
Copy link
Contributor

Changes:

  • migrating to JSON based format for module legend used by f3mon
  • adding HLTErrorEvents field which will used to distinguish between losses caused by crashes in CMSSW and other reasons, for example hardware failures.

port of #12136 submitted for 75X and #12137 submitted for 76X

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_8_0_X.

Monitoring JSON changes in DAQ (80X)

It involves the following packages:

DQMServices/Components
EventFilter/Utilities
HLTrigger/JSONMonitoring

@perrotta, @cmsbuild, @cvuosalo, @fwyzard, @emeschi, @Martin-Grunewald, @deguio, @slava77, @mommsen, @vanbesien, @danduggan can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @barvic this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mommsen
Copy link
Contributor

mommsen commented Oct 28, 2015

+1

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9259/console

@fwyzard
Copy link
Contributor

fwyzard commented Oct 28, 2015

+1

@deguio
Copy link
Contributor

deguio commented Oct 28, 2015

+1

@cmsbuild
Copy link
Contributor

-1

Tested at: 7a58df2
I found errors in the following unit tests:

---> test testPythonParameterSet had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12138/9259/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
9d76187
50895f5
deaf58f
b5589bb
9e5b112
e42a1c3
7bfe79f
368d54e
d7d8b2b
35de49e
015289e
304970d
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12138/9259/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12138/9259/git-merge-result

for(int i = 0; i < encModule_.current_; i++)
ost<<i<<"="<<((const edm::ModuleDescription *)(encModule_.decode(i)))->moduleLabel()<<" ";
return ost.str();
legendaVector.append(Json::Value(((const edm::ModuleDescription *)(encModule_.decode(i)))->moduleLabel()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid use of C style casts. The C++ casts are much easier to notIce and avoid accidental casting away can const.

cmsdqm and others added 2 commits October 30, 2015 14:10
As the name suggests, this monitors the FFF ramdisk.
Collects file delays and numbers of events.

(cherry picked from commit 7b48600)
@cmsbuild
Copy link
Contributor

-1
Tested at: 8ab7ae7
When I ran the RelVals I found an error in the following worklfows:
50202.0 step3

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log
----- Begin Fatal Exception 30-Oct-2015 13:36:46 CET-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Calling EventProcessor::runToCompletion (which does almost everything after beginJob and before endJob)
   Additional Info:
      [a] Fatal Root Error: @SUB=TFile::Flush
error flushing file step2_inDQM.root (Disk quota exceeded)
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12138/9374/summary.html

davidlange6 and others added 6 commits November 2, 2015 04:51
…11-01-2300

missing dependency added which was dropped due to DQM/HLTEvF cleanup
…iple_initialization

Initialize Sherpa only once for multiple lumi sections
Herwig: Add config for LO NNPDF30
@smorovic
Copy link
Contributor Author

smorovic commented Nov 3, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2015

Pull request #12138 was updated. @perrotta, @cmsbuild, @cvuosalo, @fwyzard, @emeschi, @Martin-Grunewald, @deguio, @slava77, @mommsen, @vanbesien, @danduggan can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Nov 3, 2015

@smorovic
there are merge conflicts in this PR. So, it can not proceed without the merge issues resolved.
Please rebase this to a more recent 80X IB (anything starting from CMSSW_8_0_X_2015-10-30-2300) and re-test there.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2015

Pull request #12138 was updated. @vciulli, @covarell, @bendavid, @danduggan, @cvuosalo, @emeschi, @thuer, @cmsbuild, @deguio, @slava77, @mommsen, @vanbesien, @govoni can you please check and sign again.

@smorovic
Copy link
Contributor Author

smorovic commented Nov 3, 2015

rebase got messed up. Will open another PR and branch for this.

@smorovic smorovic closed this Nov 3, 2015
@smorovic smorovic deleted the jsonlegends-80X branch November 13, 2015 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.