Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set class version number to 2 for CastorShowerLibraryInfo #12128

Merged
merged 1 commit into from
Oct 28, 2015
Merged

Set class version number to 2 for CastorShowerLibraryInfo #12128

merged 1 commit into from
Oct 28, 2015

Conversation

Dr15Jones
Copy link
Contributor

Philippe Canal stated that using version 1 for this case is inappropriate
and 2 should be used instead. The number 1 is reserved for 'unversioned'
classes.

@Dr15Jones
Set class version number to 2 for CastorShowerLibraryInfo
2ce99e1 
Philippe Canal stated that using version 1 for this case is inappropriate
and 2 should be used instead. The number 1 is reserved for 'unversioned'
classes.
@cmsbuild cmsbuild added this to the Next CMSSW_8_0_X milestone Oct 27, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_0_X.

Set class version number to 2 for CastorShowerLibraryInfo

It involves the following packages:

SimDataFormats/CaloHit

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9244/console

@cmsbuild
Copy link
Contributor

+1
Tested at: 2ce99e1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12128/9244/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
ac10293
56aa69e
3f1ce1f
04b1d1d
427f312
38017d3
35c378c
c2afa86
2e43936
b259a91
d8994fa
370f837
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12128/9244/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12128/9244/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12128/9244/summary.html

@civanch
Copy link
Contributor

civanch commented Oct 27, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 28, 2015
@cmsbuild
Merge pull request #12128 from Dr15Jones/fixClassVersionCastorShowerL…
304970d 
…ibraryInfo

Set class version number to 2 for CastorShowerLibraryInfo
@cmsbuild cmsbuild merged commit 304970d into cms-sw:CMSSW_8_0_X Oct 28, 2015
@Dr15Jones Dr15Jones deleted the fixClassVersionCastorShowerLibraryInfo branch December 8, 2015 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed simulation-approved tests-approved
Projects
None yet
Milestone
CMSSW_8_0_X
Development

Successfully merging this pull request may close these issues.
4 participants
@Dr15Jones @cmsbuild @civanch @davidlange6