-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MiniAOD event content updates for 76X #12122
MiniAOD event content updates for 76X #12122
Conversation
A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for CMSSW_7_6_X. MiniAOD event content updates for 76X It involves the following packages: PhysicsTools/PatAlgos @cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
@gpetruc - yes forward porting will take care |
MiniAOD event content updates for 76X
@@ -55,6 +58,8 @@ | |||
'keep *_TriggerResults_*_*', # for MET filters (a catch all for the moment, but ideally it should be only the current process) | |||
'keep patPackedCandidates_lostTracks_*_*', | |||
'keep HcalNoiseSummary_hcalnoise__*', | |||
'keep recoCSCHaloData_CSCHaloData_*_*', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one is not saved in AOD.
So, an application running on AOD will not be able to get the objects.
Since the product is needed mainly on data, it may make sense to add it to the AOD event content, otherwise it's lost.
Include a few extra quantities on miniAOD:
there will be another PR adding a few other bools to the CSCHaloData format, but that won't conflict with this PR
should we save the bunch spacing also on AOD?
even if it can be recomputed easily, it may be convenient to have it stored anyway (e.g. for people using fwlite), and the disk size cost is zero.
the branch merges also cleanly in 8_0_X: should I make a separate PR or is the auto-forward-port enabled between 7_6_X and 8_0_X?
@mariadalfonso @arizzi