Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VID python behavior and ignored cuts (76X) #12111

Merged
merged 4 commits into from
Oct 28, 2015

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Oct 27, 2015

Backport of #12110.

@lgray
Copy link
Contributor Author

lgray commented Oct 27, 2015

@cmsbuild please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Oct 27, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9218/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_6_X.

Fix VID python behavior and ignored cuts (76X)

It involves the following packages:

PhysicsTools/SelectorUtils

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

-1
Tested at: 7e42955
I found an error when building:

Entering library rule at RecoMuon/MuonIdentification
>> Building LCG reflex dict from header file src/RecoMuon/MuonIdentification/src/classes.h
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-10-26-2300/src/RecoMuon/MuonIdentification/src/CSCTimingExtractor.cc 
In file included from input_line_9:54:
In file included from /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-10-26-2300/src/PhysicsTools/SelectorUtils/interface/MakePyVIDClassBuilder.h:4:
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-10-26-2300/src/PhysicsTools/SelectorUtils/interface/VersionedSelector.h:204:61: error: use of undeclared identifier 'cname'
    CINT_GUARD(plugin = CutApplicatorFactory::get()->create(cname,*icut));
                                                            ^
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-10-26-2300/src/PhysicsTools/SelectorUtils/interface/VersionedSelector.h:17:26: note: expanded from macro 'CINT_GUARD'
#define CINT_GUARD(CODE) CODE
                         ^


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12111/9218/summary.html

@lgray
Copy link
Contributor Author

lgray commented Oct 27, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9225/console

@cmsbuild
Copy link
Contributor

Pull request #12111 was updated. @cmsbuild, @vadler, @monttj can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

davidlange6 added a commit that referenced this pull request Oct 28, 2015
Fix VID python behavior and ignored cuts (76X)
@davidlange6 davidlange6 merged commit 194b285 into cms-sw:CMSSW_7_6_X Oct 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants