-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add full5x5 shower shape block to non-GED photons producer #12086
Add full5x5 shower shape block to non-GED photons producer #12086
Conversation
A new Pull Request was created by @richard-cms (R. Alex Barbieri) for CMSSW_7_5_X. Add full5x5 shower shape block to non-GED photons producer It involves the following packages: RecoEgamma/EgammaPhotonProducers @cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Add full5x5 shower shape block to non-GED photons producer
75X backport of #12085
HI noticed that for photons produced with the "standard" photon producer, the full5x5 shower shape info was missing.
HI absolutely needs this info for photon ID purposes in run2 analyses, as we plan on using "standard" photons for run2 analyses.
@ttrk @mandrenguyen @yetkinyilmaz
We would like to request that this be included in the release used for HI data taking, potentially 7_5_3_patch2 or something similar. Apologies for not catching this error earlier.