Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated logic in HadronAndPartonSelector #12060

Conversation

ferencek
Copy link
Contributor

Updated logic of setting the parton selector only once per job in the HadronAndPartonSelector. This PR will prevent the LogWarning from being printed out every single event when the parton selection mode is undefined.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_6_X.

Updated logic in HadronAndPartonSelector

It involves the following packages:

PhysicsTools/JetMCAlgos

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@ferencek, @acaudron, @pvmulder, @imarches this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Oct 23, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9143/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

davidlange6 added a commit that referenced this pull request Nov 10, 2015
…_from-CMSSW_7_6_0_pre7

Updated logic in HadronAndPartonSelector
@davidlange6 davidlange6 merged commit 4f34efb into cms-sw:CMSSW_7_6_X Nov 10, 2015
@ferencek ferencek deleted the HadronAndPartonSelectorUpdate_from-CMSSW_7_6_0_pre7 branch November 16, 2015 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants