add a label to indentify the PFProducer calibrations #12044

fwyzard · 2015-10-22T09:30:44Z

This would be used to allow different PFCluster calibrations for online (HLT) and offline reconstruction.
The default is to use an empty label, which should be equivalent to not using any label.

cmsbuild · 2015-10-22T09:31:14Z

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_6_X.

add a label to indentify the PFProducer calibrations

It involves the following packages:

HLTrigger/Configuration
RecoParticleFlow/PFProducer

@perrotta, @cmsbuild, @cvuosalo, @slava77, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks.
@mmarionncern, @lgray, @Martin-Grunewald, @jalimena, @geoff-smith, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

cmsbuild · 2015-10-22T09:36:10Z

Pull request #12044 was updated. @perrotta, @cmsbuild, @cvuosalo, @slava77, @Martin-Grunewald, @fwyzard can you please check and sign again.

fwyzard · 2015-10-22T09:40:54Z

please test

cmsbuild · 2015-10-22T09:41:13Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9128/console

cmsbuild · 2015-10-22T11:01:02Z

-1
Tested at: 4f29d91
When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log
----- Begin Fatal Exception 22-Oct-2015 12:03:32 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 1
   [1] Running path 'reconstruction_step'
   [2] Calling beginRun for module PFProducer/'particleFlowTmp'
Exception Message:
No data of type "PerformancePayloadFromTFormula" with label "" in record "PFCalibrationRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log
----- Begin Fatal Exception 22-Oct-2015 12:05:34 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 194533
   [1] Running path 'reconstruction_step'
   [2] Calling beginRun for module PFProducer/'particleFlowTmp'
Exception Message:
No data of type "PerformancePayloadFromTFormula" with label "" in record "PFCalibrationRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log
----- Begin Fatal Exception 22-Oct-2015 12:09:50 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 182124
   [1] Running path 'reconstruction_step'
   [2] Calling beginRun for module PFProducer/'particleFlowTmp'
Exception Message:
No data of type "PerformancePayloadFromTFormula" with label "" in record "PFCalibrationRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

1306.0 step2

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 22-Oct-2015 12:13:57 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 1
   [1] Running path 'HLT_AK8PFJet360_TrimMass30_v3'
   [2] Calling beginRun for module PFProducer/'hltParticleFlow'
Exception Message:
No data of type "PerformancePayloadFromTFormula" with label "" in record "PFCalibrationRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log
----- Begin Fatal Exception 22-Oct-2015 12:14:41 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 1
   [1] Running path 'reconstruction_step'
   [2] Calling beginRun for module PFProducer/'particleFlowTmp'
Exception Message:
No data of type "PerformancePayloadFromTFormula" with label "" in record "PFCalibrationRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log
----- Begin Fatal Exception 22-Oct-2015 12:17:01 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 1
   [1] Running path 'reconstruction_step'
   [2] Calling beginRun for module PFProducer/'particleFlowTmp'
Exception Message:
No data of type "PerformancePayloadFromTFormula" with label "" in record "PFCalibrationRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log
----- Begin Fatal Exception 22-Oct-2015 12:20:18 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 1
   [1] Running path 'reconstruction_step'
   [2] Calling beginRun for module PFProducer/'particleFlowTmp'
Exception Message:
No data of type "PerformancePayloadFromTFormula" with label "" in record "PFCalibrationRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

1330.0 step2

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step2_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 22-Oct-2015 12:21:24 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 1
   [1] Running path 'HLT_AK8PFJet360_TrimMass30_v3'
   [2] Calling beginRun for module PFProducer/'hltParticleFlow'
Exception Message:
No data of type "PerformancePayloadFromTFormula" with label "" in record "PFCalibrationRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log
----- Begin Fatal Exception 22-Oct-2015 12:23:10 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 165121
   [1] Running path 'reconstruction_step'
   [2] Calling beginRun for module PFProducer/'particleFlowTmp'
Exception Message:
No data of type "PerformancePayloadFromTFormula" with label "" in record "PFCalibrationRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4.log
----- Begin Fatal Exception 22-Oct-2015 12:24:04 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 165121
   [1] Running path 'reconstruction_step'
   [2] Calling beginRun for module PFProducer/'particleFlowTmp'
Exception Message:
No data of type "PerformancePayloadFromTFormula" with label "" in record "PFCalibrationRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log
----- Begin Fatal Exception 22-Oct-2015 12:26:14 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 191226
   [1] Running path 'reconstruction_step'
   [2] Calling beginRun for module PFProducer/'particleFlowTmp'
Exception Message:
No data of type "PerformancePayloadFromTFormula" with label "" in record "PFCalibrationRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
----- Begin Fatal Exception 22-Oct-2015 12:31:08 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 1
   [1] Running path 'HLT_AK8PFJet360_TrimMass30_v3'
   [2] Calling beginRun for module PFProducer/'hltParticleFlow'
Exception Message:
No data of type "PerformancePayloadFromTFormula" with label "" in record "PFCalibrationRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

50202.0 step2

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
----- Begin Fatal Exception 22-Oct-2015 12:31:08 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing run: 1
   [1] Running path 'HLT_AK8PFJet360_TrimMass30_v2'
   [2] Calling beginRun for module PFProducer/'hltParticleFlow'
Exception Message:
No data of type "PerformancePayloadFromTFormula" with label "" in record "PFCalibrationRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12044/9128/summary.html

fwyzard · 2015-10-22T14:04:10Z

please test

cmsbuild · 2015-10-22T14:06:33Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9133/console

cmsbuild · 2015-10-22T14:06:35Z

Pull request #12044 was updated. @perrotta, @cmsbuild, @cvuosalo, @slava77, @Martin-Grunewald, @fwyzard can you please check and sign again.

fwyzard · 2015-10-22T15:59:05Z

+1

cmsbuild · 2015-10-22T16:34:56Z

+1
Tested at: 4ae9e39
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12044/9133/summary.html

cmsbuild · 2015-10-22T17:30:29Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12044/9133/summary.html

There are some workflows for which there are errors in the baseline:
4.53 step 3
25.0 step 4
1330.0 step 4
1001.0 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

slava77 · 2015-10-22T20:16:24Z

+1

for #12044 4ae9e39

code changes are in line with the PR description (the default behavior is unchanged)
jenkins tests pass and comparisons with baseline show no differences

cmsbuild · 2015-10-22T20:21:32Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 · 2015-10-23T08:19:06Z

+1

add a label to indentify the PFProducer calibrations

fwyzard · 2015-10-23T09:03:44Z

@davidlange6 , do I have to make a separate pull request for 8.0.x, or will this get propagated automatically ?

mmusich · 2015-10-23T19:39:50Z

@fwyzard GTs with the label HLT for the PFCalibrationRcd are available: #12079

fwyzard · 2015-10-25T11:32:51Z

Thanks Marco.
.A

cmsbuild added this to the Next CMSSW_7_6_X milestone Oct 22, 2015

cmsbuild added reconstruction-pending hlt-pending pending-signatures tests-pending orp-pending comparison-pending labels Oct 22, 2015

fwyzard force-pushed the add_PFCalibration_label branch from 102553d to 4f29d91 Compare October 22, 2015 09:31

cmsbuild added tests-started and removed tests-pending labels Oct 22, 2015

cmsbuild added tests-rejected and removed tests-started labels Oct 22, 2015

add a label to indentify the PFProducer calibrations

4ae9e39

fwyzard force-pushed the add_PFCalibration_label branch from 4f29d91 to 4ae9e39 Compare October 22, 2015 13:57

cmsbuild added tests-pending and removed tests-rejected labels Oct 22, 2015

cmsbuild added tests-started and removed tests-pending labels Oct 22, 2015

cmsbuild added hlt-approved and removed hlt-pending labels Oct 22, 2015

cmsbuild added tests-approved and removed tests-started labels Oct 22, 2015

cmsbuild added comparison-available and removed comparison-pending labels Oct 22, 2015

cmsbuild added reconstruction-approved fully-signed and removed pending-signatures reconstruction-pending labels Oct 22, 2015

cmsbuild added orp-approved and removed orp-pending labels Oct 23, 2015

cmsbuild added a commit that referenced this pull request Oct 23, 2015

Merge pull request #12044 from fwyzard/add_PFCalibration_label

e9dcb7f

add a label to indentify the PFProducer calibrations

cmsbuild merged commit e9dcb7f into cms-sw:CMSSW_7_6_X Oct 23, 2015

mmusich added a commit to mmusich/cmssw that referenced this pull request Oct 23, 2015

Merging cms-sw#12062 and cms-sw#12044

501fe33

diguida mentioned this pull request Oct 24, 2015

New GTs for 76X: Updates for MC DR Production and other fixes #12079

Merged

fwyzard mentioned this pull request Oct 26, 2015

use dedicated calibrations at HLT #12100

Merged

fwyzard deleted the add_PFCalibration_label branch October 29, 2015 10:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add a label to indentify the PFProducer calibrations #12044

add a label to indentify the PFProducer calibrations #12044

fwyzard commented Oct 22, 2015

cmsbuild commented Oct 22, 2015

cmsbuild commented Oct 22, 2015

fwyzard commented Oct 22, 2015

cmsbuild commented Oct 22, 2015

cmsbuild commented Oct 22, 2015

fwyzard commented Oct 22, 2015

cmsbuild commented Oct 22, 2015

cmsbuild commented Oct 22, 2015

fwyzard commented Oct 22, 2015

cmsbuild commented Oct 22, 2015

cmsbuild commented Oct 22, 2015

slava77 commented Oct 22, 2015

cmsbuild commented Oct 22, 2015

davidlange6 commented Oct 23, 2015

fwyzard commented Oct 23, 2015

mmusich commented Oct 23, 2015

fwyzard commented Oct 25, 2015

add a label to indentify the PFProducer calibrations #12044

add a label to indentify the PFProducer calibrations #12044

Conversation

fwyzard commented Oct 22, 2015

cmsbuild commented Oct 22, 2015

cmsbuild commented Oct 22, 2015

fwyzard commented Oct 22, 2015

cmsbuild commented Oct 22, 2015

cmsbuild commented Oct 22, 2015

fwyzard commented Oct 22, 2015

cmsbuild commented Oct 22, 2015

cmsbuild commented Oct 22, 2015

fwyzard commented Oct 22, 2015

cmsbuild commented Oct 22, 2015

cmsbuild commented Oct 22, 2015

slava77 commented Oct 22, 2015

cmsbuild commented Oct 22, 2015

davidlange6 commented Oct 23, 2015

fwyzard commented Oct 23, 2015

mmusich commented Oct 23, 2015

fwyzard commented Oct 25, 2015