Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused package DQM/PhysicsHWW #12020

Merged
merged 4 commits into from
Oct 24, 2015
Merged

Remove unused package DQM/PhysicsHWW #12020

merged 4 commits into from
Oct 24, 2015

Conversation

dmitrijus
Copy link
Contributor

Forward port of #11815

Dmitrijus Bugelskis added 4 commits October 15, 2015 15:01
Remove unused package DQM/PhysicsHWW
a1b4134
Remove a reference to PhysicsHWW in DQMOffline/Configuration.
f3f8a62
Remove a reference to PhysicsHWW in DQMOffline/Configuration.
1c5c8cc 
Second try!
Merge remote-tracking branch 'my-cmssw/hww_removal_75x' into from-CMS…
362bba2 
…SW_7_6_X_2015-10-20-1100

Conflicts:
	DQM/PhysicsHWW/interface/MuonEffectiveArea.h
	DQM/PhysicsHWW/interface/monitor.h
	DQM/PhysicsHWW/python/hwwDQM_cfi.py
	DQM/PhysicsHWW/src/analysisSelections.cc
	DQM/PhysicsHWW/src/electronSelections.cc
	DQM/PhysicsHWW/src/monitor.cc
@dmitrijus dmitrijus mentioned this pull request Oct 21, 2015
Closed
@deguio
Copy link
Contributor

deguio commented Oct 21, 2015

please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Oct 21, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9093/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_7_6_X.

Remove unused package DQM/PhysicsHWW

It involves the following packages:

DQM/Physics
DQM/PhysicsHWW
DQMOffline/Configuration

@cmsbuild, @danduggan, @vanbesien, @deguio can you please review it and eventually sign? Thanks.
@rappoccio, @threus, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

+1
Tested at: 362bba2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12020/9093/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
362bba2
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12020/9093/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12020/9093/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12020/9093/summary.html

@deguio
Copy link
Contributor

deguio commented Oct 23, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Oct 24, 2015
@davidlange6
Merge pull request #12020 from dmitrijus/hww_removal_76x_try2
24cd96a 
Remove unused package DQM/PhysicsHWW
@davidlange6 davidlange6 merged commit 24cd96a into cms-sw:CMSSW_7_6_X Oct 24, 2015
@davidlange6 davidlange6 mentioned this pull request Nov 8, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed orp-pending tests-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.
4 participants
@dmitrijus @deguio @cmsbuild @davidlange6