implicit tuple parameter unpacking is removed in python 3 #12009
Conversation
|
A new Pull Request was created by @ericvaandering (Eric Vaandering) for CMSSW_8_0_X. implicit tuple parameter unpacking is removed in python 3 It involves the following packages: CondCore/TagCollection @smuzaffar, @diguida, @cmsdoxy, @cerminar, @cmsbuild, @franzoni, @Dr15Jones, @ggovi, @mmusich can you please review it and eventually sign? Thanks. |
|
please test |
| @@ -120,7 +120,8 @@ def import_module(self,partnam,fqname,parent): | |||
| if r is not None: | |||
| self._depgraph.setdefault(self._last_caller.__name__,{})[r.__name__] = 1 | |||
| return r | |||
| def load_module(self, fqname, fp, pathname, (suffix, mode, type)): | |||
| def load_module(self, fqname, fp, pathname, xxx_todo_changeme): | |||
There was a problem hiding this comment.
Could you provide a better name for the variable?
There was a problem hiding this comment.
That actually comes straight from the futurize conversion, but if you have a suggestion (I think this is code you own) I will be happy to update the branch.
|
The tests are being triggered in jenkins. |
| @@ -417,10 +417,11 @@ def GetXLocator(ax): | |||
|
|
|||
| ###################################################################### | |||
|
|
|||
| def TweakPlot(fig, ax, (time_begin, time_end), | |||
| def TweakPlot(fig, ax, xxx_todo_changeme, | |||
|
please test (Will Jenkins listen to me?) |
|
Pull request #12009 was updated. @smuzaffar, @diguida, @cmsdoxy, @cerminar, @cmsbuild, @franzoni, @Dr15Jones, @ggovi, @mmusich can you please check and sign again. |
|
I guess it does. @Dr15Jones I made your suggested changes. Thanks. |
|
please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
tests-pending
comparison-pending
and removed
comparison-available
tests-approved
labels
|
@ericvaandering The tests completed for your original commit (the commit hash is at the top of the test complete message). I'm pretty sure if Jenkins was listening to your command it would have printed 'The tests are being triggered in jenkins'. |
|
+1 |
cmsbuild
added
core-approved
tests-started
and removed
core-pending
tests-pending
labels
|
Want to start them or not? I can imagine you have a list of people allowed to start tests.
Sent from a mobile device. Please excuse my brevity or transcription errors.
|
|
I did start them right before I made that comment :) |
implicit tuple parameter unpacking is removed in python 3
See: https://www.python.org/dev/peps/pep-3113/
auto-fixed by futurize