-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix packed gen particle copy and move ctors #12000
Fix packed gen particle copy and move ctors #12000
Conversation
@cmsbuild please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @wmtan for CMSSW_7_6_X. Fix packed gen particle copy and move ctors It involves the following packages: DataFormats/PatCandidates @cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks. |
What about the operator=? |
@Dr15Jones OK, I need to fix operator(s) = also. |
@Dr15Jones @davidlange6 I updated this PR both to fix the assignment operators and to use the |
@cmsbuild please test |
@vadler, @monttj @davidlange6 this is critical for fixing a bug already in the release |
…tors Fix packed gen particle copy and move ctors
Pr #11706 created explicit copy and move constructors for pat::PackedGenParticle.
Unfortunately, the packed quantities were left out, so they were neither moved nor copied.
This PR fixes that, and also enhances the unit test so that this would have been caught.
This fixes the discrepancy recently seen in PackedGenParticle.