-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix statics in DQM/BeamMonitor #11988
Conversation
There was no point to have it static anyway.
Make them members in Vx3DHLTAnalyzer. Please test before accepting.
A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_7_5_X. Fix statics in DQM/BeamMonitor It involves the following packages: DQM/BeamMonitor @cmsbuild, @danduggan, @vanbesien, @deguio can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
@dmitrijus mentioning @dinardo to inform him about the changes |
+1 |
shouldn't conflict against #12043 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Fix statics in DQM/BeamMonitor
Fix statics in DQM/BeamMonitor.
Make them members in Vx3DHLTAnalyzer.
Please test before accepting.