Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop Alignment/CocoaAnalysis package which is sub-set of Alignment/CocoaFit #11976

Merged
merged 1 commit into from
Oct 20, 2015
Merged

drop Alignment/CocoaAnalysis package which is sub-set of Alignment/CocoaFit #11976

merged 1 commit into from
Oct 20, 2015

Conversation

smuzaffar
Copy link
Contributor

No other package depends on Alignment/CocoaAnalysis

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Oct 20, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9045/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for CMSSW_7_6_X.

drop Alignment/CocoaAnalysis package which is sub-set of Alignment/CocoaFit

It involves the following packages:

Alignment/CocoaAnalysis

@cmsbuild, @mmusich, @diguida, @franzoni, @cerminar can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor

mmusich commented Oct 20, 2015

please test

@cmsbuild
Copy link
Contributor

@diguida
Copy link
Contributor

diguida commented Oct 20, 2015

@smuzaffar we need to ask the Muon HW alignment team about it.

@smuzaffar
Copy link
Contributor Author

@diguida , yes if you think that they might be using it. In that case they can move to Alignment/CocoaFit which is superset of Alignment/CocoaAnalysis

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

will remove lots of duplicate dictionaries - Thanks @smuzaffar

davidlange6 added a commit that referenced this pull request Oct 20, 2015
drop Alignment/CocoaAnalysis package which is sub-set of Alignment/CocoaFit
@davidlange6 davidlange6 merged commit f01082f into cms-sw:CMSSW_7_6_X Oct 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants