Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quieting 76x step2 and step3 #11963

Merged
merged 4 commits into from
Oct 25, 2015
Merged

Quieting 76x step2 and step3 #11963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
845c293
quiet down a lot of printouts
davidlange6 Oct 19, 2015
717546e
one more printout
davidlange6 Oct 19, 2015
43e3b94
one more printout
davidlange6 Oct 19, 2015
8e44ed5
remove duplicated steps in relvals, add gt InputTags to Pat trigger m…
davidlange6 Oct 21, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CommonTools/RecoAlgos/plugins/JetDeltaRValueMapProducer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ class JetDeltaRValueMapProducer : public edm::stream::EDProducer<> {
if( matched_index>=0 )
{
if ( matched_dR2 > distMax_*distMax_ )
edm::LogWarning("MatchedJetsFarApart") << "Matched jets separated by dR greater than distMax=" << distMax_;
edm::LogInfo("MatchedJetsFarApart") << "Matched jets separated by dR greater than distMax=" << distMax_;
else
{
jets1_locks.at(matched_index) = true;
Expand Down
26 changes: 13 additions & 13 deletions Configuration/PyReleaseValidation/python/relval_steps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,45 +788,45 @@ def identityFS(wf):
steps['FS_TTbar_13_PUAVE35_DRMIX_ITO']=merge([PUFSAVE35_DRMIX_ITO,Kby(100,500),steps['TTbarFS_13']] ) # needs the placeholder

# step2
step2Defaults = { '-s' : 'DIGI:pdigi_valid,L1,DIGI2RAW,HLT:@fake,RAW2DIGI,L1Reco',
step2Defaults = { '-s' : 'DIGI:pdigi_valid,L1,DIGI2RAW,HLT:@fake',
'--datatier' : 'GEN-SIM-DIGI-RAW-HLTDEBUG',
'--eventcontent': 'FEVTDEBUGHLT',
'--conditions' : 'auto:run1_mc',
}
#for 2015
step2Upg2015Defaults = {'-s' :'DIGI:pdigi_valid,L1,DIGI2RAW,HLT:@relval25ns,RAW2DIGI,L1Reco',
step2Upg2015Defaults = {'-s' :'DIGI:pdigi_valid,L1,DIGI2RAW,HLT:@relval25ns',
'--conditions' :'auto:run2_mc_'+autoHLT['relval25ns'],
'--datatier' :'GEN-SIM-DIGI-RAW-HLTDEBUG',
'--eventcontent':'FEVTDEBUGHLT',
'--era' :'Run2_25ns',
'-n' :'10'
}
step2Upg2015Defaults50ns = merge([{'-s':'DIGI:pdigi_valid,L1,DIGI2RAW,HLT:@relval50ns,RAW2DIGI,L1Reco','--conditions':'auto:run2_mc_'+autoHLT['relval50ns'],'--era':'Run2_50ns'},step2Upg2015Defaults])
step2Upg2015Defaults50ns = merge([{'-s':'DIGI:pdigi_valid,L1,DIGI2RAW,HLT:@relval50ns','--conditions':'auto:run2_mc_'+autoHLT['relval50ns'],'--era':'Run2_50ns'},step2Upg2015Defaults])

steps['DIGIUP15']=merge([step2Upg2015Defaults])
steps['DIGIUP15PROD1']=merge([{'-s':'DIGI,L1,DIGI2RAW,HLT:@relval25ns,RAW2DIGI,L1Reco','--eventcontent':'RAWSIM','--datatier':'GEN-SIM-RAW'},step2Upg2015Defaults])
steps['DIGIUP15PROD1']=merge([{'-s':'DIGI,L1,DIGI2RAW,HLT:@relval25ns','--eventcontent':'RAWSIM','--datatier':'GEN-SIM-RAW'},step2Upg2015Defaults])
steps['DIGIUP15_PU25']=merge([PU25,step2Upg2015Defaults])
steps['DIGIUP15_PU50']=merge([PU50,step2Upg2015Defaults50ns])

steps['DIGIPROD1']=merge([{'-s':'DIGI,L1,DIGI2RAW,HLT:@fake,RAW2DIGI,L1Reco','--eventcontent':'RAWSIM','--datatier':'GEN-SIM-RAW'},step2Defaults])
steps['DIGIPROD1']=merge([{'-s':'DIGI,L1,DIGI2RAW,HLT:@fake','--eventcontent':'RAWSIM','--datatier':'GEN-SIM-RAW'},step2Defaults])
steps['DIGI']=merge([step2Defaults])
#steps['DIGI2']=merge([stCond,step2Defaults])
steps['DIGICOS']=merge([{'--scenario':'cosmics','--eventcontent':'FEVTDEBUG','--datatier':'GEN-SIM-DIGI-RAW'},stCond,step2Defaults])
steps['DIGIHAL']=merge([{'--scenario':'cosmics','--eventcontent':'FEVTDEBUG','--datatier':'GEN-SIM-DIGI-RAW'},step2Upg2015Defaults])

steps['DIGIPU1']=merge([PU,step2Defaults])
steps['DIGIPU2']=merge([PU2,step2Defaults])
steps['REDIGIPU']=merge([{'-s':'reGEN,reDIGI,L1,DIGI2RAW,HLT:@fake,RAW2DIGI,L1Reco'},steps['DIGIPU1']])
steps['REDIGIPU']=merge([{'-s':'reGEN,reDIGI,L1,DIGI2RAW,HLT:@fake'},steps['DIGIPU1']])

steps['DIGIUP15_ID']=merge([{'--restoreRND':'HLT','--process':'HLT2'},steps['DIGIUP15']])

steps['RESIM']=merge([{'-s':'reGEN,reSIM','-n':10},steps['DIGI']])
#steps['RESIMDIGI']=merge([{'-s':'reGEN,reSIM,DIGI,L1,DIGI2RAW,HLT:@fake,RAW2DIGI,L1Reco','-n':10,'--restoreRNDSeeds':'','--process':'HLT'},steps['DIGI']])


steps['DIGIHI']=merge([{'-s':'DIGI:pdigi_valid,L1,DIGI2RAW,HLT:HIon,RAW2DIGI,L1Reco'}, hiDefaults, step2Upg2015Defaults])
steps['DIGIHI2011']=merge([{'-s':'DIGI:pdigi_valid,L1,DIGI2RAW,HLT:@fake,RAW2DIGI,L1Reco'}, hiDefaults2011, step2Defaults])
steps['DIGIHIMIX']=merge([{'-s':'DIGI:pdigi_valid,L1,DIGI2RAW,HLT:HIon,RAW2DIGI,L1Reco', '-n':2}, hiDefaults, {'--pileup':'HiMix'}, PUHI, step2Upg2015Defaults])
steps['DIGIHI']=merge([{'-s':'DIGI:pdigi_valid,L1,DIGI2RAW,HLT:HIon'}, hiDefaults, step2Upg2015Defaults])
steps['DIGIHI2011']=merge([{'-s':'DIGI:pdigi_valid,L1,DIGI2RAW,HLT:@fake'}, hiDefaults2011, step2Defaults])
steps['DIGIHIMIX']=merge([{'-s':'DIGI:pdigi_valid,L1,DIGI2RAW,HLT:HIon', '-n':2}, hiDefaults, {'--pileup':'HiMix'}, PUHI, step2Upg2015Defaults])


# PRE-MIXING : https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideSimulation#Pre_Mixing_Instructions
Expand All @@ -848,24 +848,24 @@ def identityFS(wf):

digiPremixUp2015Defaults25ns = {
'--conditions' : 'auto:run2_mc_'+autoHLT['relval25ns'],
'-s' : 'DIGIPREMIX_S2:pdigi_valid,DATAMIX,L1,DIGI2RAW,HLT:@relval25ns,RAW2DIGI,L1Reco',
'-s' : 'DIGIPREMIX_S2:pdigi_valid,DATAMIX,L1,DIGI2RAW,HLT:@relval25ns',
'--pileup_input' : 'das:/RelValPREMIXUP15_PU25/%s/GEN-SIM-DIGI-RAW'%baseDataSetRelease[5],
'--eventcontent' : 'FEVTDEBUGHLT',
'--datatier' : 'GEN-SIM-DIGI-RAW-HLTDEBUG',
'--datamix' : 'PreMix',
'--customise' : 'SLHCUpgradeSimulations/Configuration/postLS1CustomsPreMixing.customisePostLS1'
}
digiPremixUp2015Defaults50ns=merge([{'-s':'DIGIPREMIX_S2:pdigi_valid,DATAMIX,L1,DIGI2RAW,HLT:@relval50ns,RAW2DIGI,L1Reco'},
digiPremixUp2015Defaults50ns=merge([{'-s':'DIGIPREMIX_S2:pdigi_valid,DATAMIX,L1,DIGI2RAW,HLT:@relval50ns'},
{'--conditions':'auto:run2_mc_'+autoHLT['relval50ns']},
{'--pileup_input' : 'das:/RelValPREMIXUP15_PU50/%s/GEN-SIM-DIGI-RAW'%baseDataSetRelease[6]},
{'--customise': 'SLHCUpgradeSimulations/Configuration/postLS1CustomsPreMixing.customisePostLS1_50ns'},
digiPremixUp2015Defaults25ns])
steps['DIGIPRMXUP15_PU25']=merge([digiPremixUp2015Defaults25ns])
steps['DIGIPRMXUP15_PU50']=merge([digiPremixUp2015Defaults50ns])
premixProd25ns = {'-s' : 'DIGIPREMIX_S2,DATAMIX,L1,DIGI2RAW,HLT:@relval25ns,RAW2DIGI,L1Reco',
premixProd25ns = {'-s' : 'DIGIPREMIX_S2,DATAMIX,L1,DIGI2RAW,HLT:@relval25ns',
'--eventcontent' : 'PREMIXRAW',
'--datatier' : 'PREMIXRAW'}
premixProd50ns = merge([{'-s':'DIGIPREMIX_S2,DATAMIX,L1,DIGI2RAW,HLT:@relval50ns,RAW2DIGI,L1Reco'},premixProd25ns])
premixProd50ns = merge([{'-s':'DIGIPREMIX_S2,DATAMIX,L1,DIGI2RAW,HLT:@relval50ns'},premixProd25ns])

steps['DIGIPRMXUP15_PROD_PU25']=merge([premixProd25ns,digiPremixUp2015Defaults25ns])
steps['DIGIPRMXUP15_PROD_PU50']=merge([premixProd50ns,digiPremixUp2015Defaults50ns])
Expand Down
12 changes: 6 additions & 6 deletions DPGAnalysis/Skims/src/LogErrorEventFilter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,12 +127,12 @@ LogErrorEventFilter::LogErrorEventFilter(const edm::ParameterSet & iConfig) :
categoriesToIgnore_.insert(categories.begin(), categories.end());
}
}
std::ostream_iterator<std::string> dump(std::cout, ", ");
std::cout << "\nWatch modules: " ; std::copy(modulesToWatch_.begin(), modulesToWatch_.end(), dump);
std::cout << "\nIgnore modules: " ; std::copy(modulesToIgnore_.begin(), modulesToIgnore_.end(), dump);
std::cout << "\nIgnore categories: " ; std::copy(categoriesToIgnore_.begin(), categoriesToIgnore_.end(), dump);
std::cout << "\nWatch categories: " ; std::copy(categoriesToWatch_.begin(), categoriesToWatch_.end(), dump);
std::cout << std::endl;
//std::ostream_iterator<std::string> dump(std::cout, ", ");
//std::cout << "\nWatch modules: " ; std::copy(modulesToWatch_.begin(), modulesToWatch_.end(), dump);
//std::cout << "\nIgnore modules: " ; std::copy(modulesToIgnore_.begin(), modulesToIgnore_.end(), dump);
//std::cout << "\nIgnore categories: " ; std::copy(categoriesToIgnore_.begin(), categoriesToIgnore_.end(), dump);
//std::cout << "\nWatch categories: " ; std::copy(categoriesToWatch_.begin(), categoriesToWatch_.end(), dump);
//std::cout << std::endl;

}

Expand Down
2 changes: 1 addition & 1 deletion DQMOffline/Trigger/src/HLTTauDQMPath.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ namespace {
// ignore
}
else {
edm::LogWarning("HLTTauDQMOfflineSource") << "HLTTauDQMPath.cc, inferTauLeptonMultiplicity(): module type '" << moduleType << "' not recognized, filter '" << filterName << "' in path '" << pathName << "' will be ignored for offline matching." << std::endl;
edm::LogInfo("HLTTauDQMOfflineSource") << "HLTTauDQMPath.cc, inferTauLeptonMultiplicity(): module type '" << moduleType << "' not recognized, filter '" << filterName << "' in path '" << pathName << "' will be ignored for offline matching." << std::endl;
}
return n;
}
Expand Down
2 changes: 1 addition & 1 deletion HLTriggerOffline/Egamma/src/EmDQM.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ EmDQM::dqmBeginRun(edm::Run const &iRun, edm::EventSetup const &iSetup)
edm::LogPrint("EmDQM") << "No number of candidates for filter " << moduleLabel << " found. Set to " << paramSet.getParameter<int>("cutnum") << ", determined from path name.";
filterPSet.addParameter<int>("ncandcut", paramSet.getParameter<int>("cutnum"));
} else if (filterPSet.getParameter<int>("ncandcut") > paramSet.getParameter<int>("cutnum")) {
edm::LogPrint("EmDQM") << "Changed required number of candidates from " << paramSet.getParameter<int>("cutnum") << " to " << filterPSet.getParameter<int>("ncandcut") << " for filter " << moduleLabel;
edm::LogInfo("EmDQM") << "Changed required number of candidates from " << paramSet.getParameter<int>("cutnum") << " to " << filterPSet.getParameter<int>("ncandcut") << " for filter " << moduleLabel;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, rather than changing the LogPrint to a LogInfo, why not change it to a LogWarning and fix the configuration ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great. as I said in the PR itself "if these are considered bugs, we can reenable them together with the bug fix..” Maybe @deguio wants to comment on the interest of the developers to fix

On Oct 22, 2015, at 9:37 AM, Andrea Bocci [email protected] wrote:

In HLTriggerOffline/Egamma/src/EmDQM.cc:

@@ -328,7 +328,7 @@ EmDQM::dqmBeginRun(edm::Run const &iRun, edm::EventSetup const &iSetup)
edm::LogPrint("EmDQM") << "No number of candidates for filter " << moduleLabel << " found. Set to " << paramSet.getParameter("cutnum") << ", determined from path name.";
filterPSet.addParameter("ncandcut", paramSet.getParameter("cutnum"));
} else if (filterPSet.getParameter("ncandcut") > paramSet.getParameter("cutnum")) {

  •                  edm::LogPrint("EmDQM") << "Changed required number of candidates from " << paramSet.getParameter<int>("cutnum") << " to " << filterPSet.getParameter<int>("ncandcut") << " for filter " << moduleLabel;

  •                  edm::LogInfo("EmDQM") << "Changed required number of candidates from " << paramSet.getParameter<int>("cutnum") << " to " << filterPSet.getParameter<int>("ncandcut") << " for filter " << moduleLabel;

Again, rather than changing the LogPrint to a LogInfo, why not change it to a LogWarning and fix the configuration ?

—
Reply to this email directly or view it on GitHub.

paramSet.addParameter<int>("cutnum", filterPSet.getParameter<int>("ncandcut"));
paramSet.addParameter<unsigned>("reqNum", (unsigned)filterPSet.getParameter<int>("ncandcut"));
}
Expand Down
2 changes: 1 addition & 1 deletion L1Trigger/GlobalTriggerAnalyzer/src/L1GtUtils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,7 +888,7 @@ const int L1GtUtils::l1Results(const edm::Event& iEvent,

} else {

LogDebug("L1GtUtils") << "\nError: "
LogDebug("L1GtUtils") << "\nError: "
<< "\nNo valid L1GlobalTriggerRecord with \n "
<< m_l1GtUtilsHelper->l1GtRecordInputTag() << "\nfound in the event."
<< "\nNo valid L1GlobalTriggerReadoutRecord with \n "
Expand Down
10 changes: 4 additions & 6 deletions L1Trigger/GlobalTriggerAnalyzer/src/L1GtUtilsHelper.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ void L1GtUtilsHelper::operator()(
branchDescription.processName() };

if (m_foundPreferredRecord) {

// check if a preferred input tag was already found and compare it with the actual tag
// if the instance or the process names are different, one has incompatible tags - set
// the tag to empty input tag and indicate that multiple preferred input tags are found
Expand All @@ -95,9 +94,9 @@ void L1GtUtilsHelper::operator()(
!= branchDescription.productInstanceName())
|| (m_l1GtRecordInputTag.process()
!= branchDescription.processName()))) {

LogDebug("L1GtUtils")
<< "\nWARNING: Found multiple preferred input tags for L1GlobalTriggerRecord product, "
LogDebug("L1GtUtils")
<< "\nWARNING: Found multiple preferred input tags for L1GlobalTriggerRecord product, "
<< "\nwith different instaces or processes."
<< "\nInput tag already found: "
<< (m_l1GtRecordInputTag) << "\nActual tag: " << (tag)
Expand All @@ -107,8 +106,7 @@ void L1GtUtilsHelper::operator()(
m_l1GtRecordInputTag = edm::InputTag();
}
} else {
// no preferred input tag found yet, check now with the actual tag

// no preferred input tag found yet, check now with the actual tag
for (std::vector<edm::InputTag>::const_iterator itPrefTag =
preferredL1GtRecordInputTag.begin(), itPrefTagEnd =
preferredL1GtRecordInputTag.end();
Expand Down
2 changes: 1 addition & 1 deletion PhysicsTools/JetMCAlgos/plugins/HadronAndPartonSelector.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ HadronAndPartonSelector::produce(edm::Event& iEvent, const edm::EventSetup& iSet
if( !partonSelector_ )
{
if ( partonMode_=="Undefined" )
edm::LogWarning("UndefinedPartonMode") << "Could not automatically determine the hadronizer type and set the correct parton selection mode. Parton-based jet flavour will not be defined.";
edm::LogInfo("UndefinedPartonMode") << "Could not automatically determine the hadronizer type and set the correct parton selection mode. Parton-based jet flavour will not be defined.";
else if ( partonMode_=="Pythia6" )
{
partonSelector_ = PartonSelectorPtr( new Pythia6PartonSelector() );
Expand Down
2 changes: 1 addition & 1 deletion PhysicsTools/PatAlgos/plugins/JetCorrFactorsProducer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ JetCorrFactorsProducer::JetCorrFactorsProducer(const edm::ParameterSet& cfg):
}
}
else{
edm::LogWarning message( "Parameter rho not used" );
edm::LogInfo message( "Parameter rho not used" );
message << "Module is configured to use the parameter rho, but rho is only used \n"
<< "for L1FastJet corrections. The configuration of levels does not contain \n"
<< "L1FastJet corrections though, so rho will not be used by this module. \n";
Expand Down
4 changes: 4 additions & 0 deletions PhysicsTools/PatAlgos/python/triggerLayer1/triggerProducer_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

patTrigger = cms.EDProducer( "PATTriggerProducer"
, onlyStandAlone = cms.bool( False )
,l1GtRecordInputTag = cms.InputTag("gtDigis")
,l1GtReadoutRecordInputTag = cms.InputTag("gtDigis")
,l1GtTriggerMenuLiteInputTag = cms.InputTag("gtDigis")

# ## L1
# , addL1Algos = cms.bool( False ) # default; possibly superseded by 'onlyStandAlone' = True
# , l1GlobalTriggerObjectMaps = cms.InputTag( "l1L1GtObjectMap" ) # default; change only, if you know exactly, what you are doing!
Expand Down
4 changes: 0 additions & 4 deletions PhysicsTools/PatUtils/interface/ShiftedJetProducerT.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,9 @@ template <typename T, typename Textractor>
jetCorrInputFileName_ = cfg.getParameter<edm::FileInPath>("jetCorrInputFileName");
if ( jetCorrInputFileName_.location() == edm::FileInPath::Unknown) throw cms::Exception("ShiftedJetProducerT")
<< " Failed to find JEC parameter file = " << jetCorrInputFileName_ << " !!\n";
std::cout << "Reading JEC parameters = " << jetCorrUncertaintyTag_
<< " from file = " << jetCorrInputFileName_.fullPath() << "." << std::endl;
jetCorrParameters_ = new JetCorrectorParameters(jetCorrInputFileName_.fullPath().data(), jetCorrUncertaintyTag_);
jecUncertainty_ = new JetCorrectionUncertainty(*jetCorrParameters_);
} else {
std::cout << "Reading JEC parameters = " << jetCorrUncertaintyTag_
<< " from DB/SQLlite file." << std::endl;
jetCorrPayloadName_ = cfg.getParameter<std::string>("jetCorrPayloadName");
}
}
Expand Down
4 changes: 0 additions & 4 deletions PhysicsTools/PatUtils/plugins/ShiftedPFCandidateProducerForNoPileUpPFMEt.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,9 @@ ShiftedPFCandidateProducerForNoPileUpPFMEt::ShiftedPFCandidateProducerForNoPileU
jetCorrInputFileName_ = cfg.getParameter<edm::FileInPath>("jetCorrInputFileName");
if ( jetCorrInputFileName_.location() == edm::FileInPath::Unknown) throw cms::Exception("ShiftedJetProducerT")
<< " Failed to find JEC parameter file = " << jetCorrInputFileName_ << " !!\n";
std::cout << "Reading JEC parameters = " << jetCorrUncertaintyTag_
<< " from file = " << jetCorrInputFileName_.fullPath() << "." << std::endl;
jetCorrParameters_ = new JetCorrectorParameters(jetCorrInputFileName_.fullPath().data(), jetCorrUncertaintyTag_);
jecUncertainty_ = new JetCorrectionUncertainty(*jetCorrParameters_);
} else {
std::cout << "Reading JEC parameters = " << jetCorrUncertaintyTag_
<< " from DB/SQLlite file." << std::endl;
jetCorrPayloadName_ = cfg.getParameter<std::string>("jetCorrPayloadName");
}

Expand Down
4 changes: 2 additions & 2 deletions PhysicsTools/PatUtils/plugins/ShiftedPFCandidateProducerForPFNoPUMEt.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@ ShiftedPFCandidateProducerForPFNoPUMEt::ShiftedPFCandidateProducerForPFNoPUMEt(c
jetCorrInputFileName_ = cfg.getParameter<edm::FileInPath>("jetCorrInputFileName");
if ( jetCorrInputFileName_.location() == edm::FileInPath::Unknown) throw cms::Exception("ShiftedJetProducerT")
<< " Failed to find JEC parameter file = " << jetCorrInputFileName_ << " !!\n";
edm::LogWarning("ShiftedPFCandidateProducerForPFNoPUMEt")
edm::LogInfo("ShiftedPFCandidateProducerForPFNoPUMEt")
<< "Reading JEC parameters = " << jetCorrUncertaintyTag_
<< " from file = " << jetCorrInputFileName_.fullPath() << "." << std::endl;
jetCorrParameters_ = new JetCorrectorParameters(jetCorrInputFileName_.fullPath().data(), jetCorrUncertaintyTag_);
jecUncertainty_ = new JetCorrectionUncertainty(*jetCorrParameters_);
} else {
edm::LogWarning("ShiftedPFCandidateProducerForPFNoPUMEt")
edm::LogInfo("ShiftedPFCandidateProducerForPFNoPUMEt")
<< "Reading JEC parameters = " << jetCorrUncertaintyTag_
<< " from DB/SQLlite file." << std::endl;
jetCorrPayloadName_ = cfg.getParameter<std::string>("jetCorrPayloadName");
Expand Down
2 changes: 1 addition & 1 deletion PhysicsTools/SelectorUtils/interface/VersionedIdProducer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ VersionedIdProducer(const edm::ParameterSet& iConfig) {
}

if( idMD5 != calculated_md5 ) {
edm::LogError("IdConfigurationNotValidated")
edm::LogInfo("IdConfigurationNotValidated")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lgray
please note

If I understand correctly, with md5 check machinery not working, a noticeable feature of VIDs to be able to validate the configuration is dead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still trying to understand it. I am somewhat annoyed if I have to keep updating it over time for no reason...
Also, other bigger things in front of it. It's OK to turn it off for now.
I'll hopefully be able to turn it back on later.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, wouldn't say that a major feature is missing. It's possible to check git hashes as well (which appear to be more stable somehow...), so there are ways around it and it's not "a significantly missing piece and the validation is dead otherwise". One that is rather nice to have though, still possible to validate by git repo states.

<< "ID: " << ids_.back()->name() << "\n"
<< "The expected md5: " << idMD5 << " does not match the md5\n"
<< "calculated by the ID: " << calculated_md5 << " please\n"
Expand Down
6 changes: 3 additions & 3 deletions PhysicsTools/SelectorUtils/python/tools/vid_id_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def setupVIDSelection(vidproducer,cutflow):
isPOGApproved = isPOGApproved,
idMD5 = cms.string(cutflow_md5) )
)
sys.stderr.write('Added ID \'%s\' to %s\n'%(cutflow.idName.value(),vidproducer.label()))
# sys.stderr.write('Added ID \'%s\' to %s\n'%(cutflow.idName.value(),vidproducer.label()))

def addVIDSelectionToPATProducer(patProducer,idProducer,idName,addUserData=True):
patProducerIDs = None
Expand Down Expand Up @@ -83,7 +83,7 @@ def switchOnVIDElectronIdProducer(process, dataFormat):
else:
raise Exception('InvalidVIDDataFormat', 'The requested data format is different from AOD or MiniAOD')
#
sys.stderr.write('Added \'egmGsfElectronIDs\' to process definition (%s format)!\n' % dataFormatString)
# sys.stderr.write('Added \'egmGsfElectronIDs\' to process definition (%s format)!\n' % dataFormatString)

def setupVIDElectronSelection(process,cutflow,patProducer=None,addUserData=True):
if not hasattr(process,'egmGsfElectronIDs'):
Expand Down Expand Up @@ -119,7 +119,7 @@ def switchOnVIDMuonIdProducer(process, dataFormat):
else:
raise Exception('InvalidVIDDataFormat', 'The requested data format is different from AOD or MiniAOD')
#
sys.stderr.write('Added \'muoMuonIDs\' to process definition (%s format)!\n' % dataFormatString)
# sys.stderr.write('Added \'muoMuonIDs\' to process definition (%s format)!\n' % dataFormatString)

def setupVIDMuonSelection(process,cutflow,patProducer=None):
moduleName = "muoMuonIDs"
Expand Down
2 changes: 1 addition & 1 deletion RecoPixelVertexing/PixelVertexFinding/src/PixelVertexProducer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ PixelVertexProducer::PixelVertexProducer(const edm::ParameterSet& conf)
track_pt_min = PVcomparerPSet.getParameter<double>("track_pt_min");
if (track_pt_min != ptMin_) {
if (track_pt_min < ptMin_)
edm::LogWarning("PixelVertexProducer") << "minimum track pT setting differs between PixelVertexProducer (" << ptMin_ << ") and PVcomparer (" << track_pt_min << ") [PVcomparer considers tracks w/ lower threshold than PixelVertexProducer does] !!!";
edm::LogInfo("PixelVertexProducer") << "minimum track pT setting differs between PixelVertexProducer (" << ptMin_ << ") and PVcomparer (" << track_pt_min << ") [PVcomparer considers tracks w/ lower threshold than PixelVertexProducer does] !!!";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arizzi @rovere @VinInn @ferencek
please check this is OK

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess @silviodonato can comment... if this is firing we have to fix the config I guess... can you clarify in which context was it firing too often?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can check, e.g. 134.702 in step2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it happens once per job

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@silviodonato can you have a look?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidlange6 are we going to make 5 billion jobs for 5 billion events? that's inefficient :-) This Warning is at construction time right? so it complains once per job at most... I guess config warning should be print once per job ... we have no way to print "once per production campaign" given that jobs do not talk with each other

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure - but why keep warnings around for years? Its not “new"

On Oct 21, 2015, at 3:58 PM, arizzi [email protected] wrote:

In RecoPixelVertexing/PixelVertexFinding/src/PixelVertexProducer.cc:

@@ -41,7 +41,7 @@ PixelVertexProducer::PixelVertexProducer(const edm::ParameterSet& conf)
track_pt_min = PVcomparerPSet.getParameter("track_pt_min");
if (track_pt_min != ptMin_) {
if (track_pt_min < ptMin_)

  • edm::LogWarning("PixelVertexProducer") << "minimum track pT setting differs between PixelVertexProducer (" << ptMin_ << ") and PVcomparer (" << track_pt_min << ") [PVcomparer considers tracks w/ lower threshold than PixelVertexProducer does] !!!";
  • edm::LogInfo("PixelVertexProducer") << "minimum track pT setting differs between PixelVertexProducer (" << ptMin_ << ") and PVcomparer (" << track_pt_min << ") [PVcomparer considers tracks w/ lower threshold than PixelVertexProducer does] !!!";

@davidlange6 are we going to make 5 billion jobs for 5 billion events? that's inefficient :-) This Warning is at construction time right? so it complains once per job at most... I guess config warning should be print once per job ... we have no way to print "once per production campaign" given that jobs do not talk with each other

—
Reply to this email directly or view it on GitHub.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Andrea
I’m silencing in the message logger using the same-since-ever configuration for production. The issue that no one seems to be aware of this message present during all 2015 production is a sign of how useful it is. Certainly there is plenty of time to understand the consequence now that I’ve raised awareness of it for the 2016 menus. We will continue to have it for 74x and 75x data taking in case further reminders are needed.

On Oct 21, 2015, at 3:51 PM, Andrea Bocci [email protected] wrote:

In RecoPixelVertexing/PixelVertexFinding/src/PixelVertexProducer.cc:

@@ -41,7 +41,7 @@ PixelVertexProducer::PixelVertexProducer(const edm::ParameterSet& conf)
track_pt_min = PVcomparerPSet.getParameter("track_pt_min");
if (track_pt_min != ptMin_) {
if (track_pt_min < ptMin_)

  • edm::LogWarning("PixelVertexProducer") << "minimum track pT setting differs between PixelVertexProducer (" << ptMin_ << ") and PVcomparer (" << track_pt_min << ") [PVcomparer considers tracks w/ lower threshold than PixelVertexProducer does] !!!";
  • edm::LogInfo("PixelVertexProducer") << "minimum track pT setting differs between PixelVertexProducer (" << ptMin_ << ") and PVcomparer (" << track_pt_min << ") [PVcomparer considers tracks w/ lower threshold than PixelVertexProducer does] !!!";

On 21 October 2015 at 15:41, David Lange [email protected] wrote: we really need more than 5 billion MC events worth of the printout?
As I did write: no. You can silence it in the MessageLogger configuration. I don't think it makes sense to make the change in the HLT menu now - the next occasion to review the impact of the change (though none is expected) would be next Thursday, with only few days of data taking left. In any case, do not downgrade the LogWarning to a LogInfo, just because it is doing its job of catching the problem it was intended to catch. .Andrea
—
Reply to this email directly or view it on GitHub.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because nobody complained/noticed it earlier, and the fix is "fix the config".
It is not "years" it is at most "1 year", in fact less given the the config change was integrated (checking JIRA) on Nov 5th 2014

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems we now agree the printout has accomplished its goal. if things return back to the state where it indicates a real unknown problem, it would then be good to reenable by default as a warning. Meanwhile we can more easily see other warnings

On Oct 21, 2015, at 4:10 PM, arizzi [email protected] wrote:

In RecoPixelVertexing/PixelVertexFinding/src/PixelVertexProducer.cc:

@@ -41,7 +41,7 @@ PixelVertexProducer::PixelVertexProducer(const edm::ParameterSet& conf)
track_pt_min = PVcomparerPSet.getParameter("track_pt_min");
if (track_pt_min != ptMin_) {
if (track_pt_min < ptMin_)

  • edm::LogWarning("PixelVertexProducer") << "minimum track pT setting differs between PixelVertexProducer (" << ptMin_ << ") and PVcomparer (" << track_pt_min << ") [PVcomparer considers tracks w/ lower threshold than PixelVertexProducer does] !!!";
  • edm::LogInfo("PixelVertexProducer") << "minimum track pT setting differs between PixelVertexProducer (" << ptMin_ << ") and PVcomparer (" << track_pt_min << ") [PVcomparer considers tracks w/ lower threshold than PixelVertexProducer does] !!!";

because nobody complained/noticed it earlier, and the fix is "fix the config".
It is not "years" it is at most "1 year", in fact less given the the config change was integrated (checking JIRA) on Nov 5th 2014

—
Reply to this email directly or view it on GitHub.

else
edm::LogInfo("PixelVertexProducer") << "minimum track pT setting differs between PixelVertexProducer (" << ptMin_ << ") and PVcomparer (" << track_pt_min << ") !!!";
}
Expand Down
2 changes: 1 addition & 1 deletion SimMuon/MCTruth/src/RPCHitAssociator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ std::vector<RPCHitAssociator::SimHitIdpr> RPCHitAssociator::associateRecHit(cons
for(int i = fstrip; i < fstrip+cls; ++i) {
std::set<RPCDigiSimLink> links = findRPCDigiSimLink(rpcDetId.rawId(),i,bx);

if (links.empty()) edm::LogWarning("RPCHitAssociator")
if (links.empty()) edm::LogInfo("RPCHitAssociator")
<<"*** WARNING in RPCHitAssociator::associateRecHit, RPCRecHit "<<*rpcrechit<<", strip "<<i<<" has no associated RPCDigiSimLink !"<<endl;

for(std::set<RPCDigiSimLink>::iterator itlink = links.begin(); itlink != links.end(); ++itlink) {
Expand Down
Loading