EP code bug fix

[BetterWang]

Bug fix, urgent for HI run.

[cmsbuild]

A new Pull Request was created by @BetterWang (Quan Wang) for CMSSW_7_6_X.

EP code bug fix

It involves the following packages:

RecoHI/HiEvtPlaneAlgos

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@jazzitup, @dgulhan, @yenjie, @kurtejung, @istaslis, @mandrenguyen, @richard-cms, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8937/console

[cmsbuild]

+1
Tested at: 884d14b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11835/8937/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11835/8937/summary.html

[cvuosalo]

@BetterWang: Please explain what changes in reconstruction will result from your bug fix.

[BetterWang]

Hi @cvuosalo , there is no change in the reco step.
The bug affects only calibrations read from the confdb.

[cvuosalo]

+1

For #11835 884d14b

Small bug fix for Heavy Ions in HiEvtPlaneAlgos. The fix only affects calibrations and should not change RECO quantities. #11836 is the 75X version of this PR, and it has already been approved by Reco.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_6_X_2015-10-15-2300 show no significant differences, as expected. An additional test was done for #11836 that also showed no significant differences.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1