-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PCC ntupler 76x - October2015 #11832
Conversation
…or data certification with express stream
A new Pull Request was created by @capalmer85 for CMSSW_7_6_X. PCC ntupler 76x - October2015 It involves the following packages: RecoLuminosity/LumiProducer @cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks. |
@davidlange6 @slava77 I'd like to get this merged relatively quickly because there are some significant updates that the lumi data certifiers need access to on a short time scale. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
|
||
if(includeJets){ | ||
hltjetsToken_=consumes<reco::CaloJetCollection >(edm::InputTag("ak4CaloJets")); | ||
const int kMaxJetCal = 10000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10k ak4 jets can't fit into CMS acceptance.
This looks excessive regarding memory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I stole this from elsewhere in cmssw, so I didn't look too carefully.)
const int kMaxJetCal = 10000; |
What value would be acceptable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
even 100 is plenty enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
@cmsbuild please test |
The tests are being triggered in jenkins. |
@slava77 when should this be merged? |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
PCC ntupler 76x - October2015
update with BX splitting option;
includeJets (default off);
add .py for data certification with express stream