Adding no-HF grid-based rho #11771
Adding no-HF grid-based rho #11771
Conversation
|
A new Pull Request was created by @rappoccio for CMSSW_7_4_X. Adding no-HF grid-based rho It involves the following packages: RecoJets/Configuration @cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks. |
|
@cmsbuild please test |
|
@rappoccio |
|
The tests are being triggered in jenkins. |
|
at least this morning there was no discussion of another re-miniAOD. |
|
The details were not clear to me either. If we end up with a miniAOD "silver version" then that is a better place, I agree. |
| @@ -61,6 +61,9 @@ | |||
| ) | |||
|
|
|||
|
|
|||
| fixedGridRhoFastjetCentral = fixedGridRhoFastjetAll.clone( | |||
| maxRapidity = cms.double(2.5) | |||
| ) | |||
There was a problem hiding this comment.
I suppose if that recipe includes
from RecoJets/Configuration/RecoPFJets_cff import fixedGridRhoFastjetCentral
it would still kind of work.
Still, considering the inclusive keep *_fixedGridRho*_*_* that we have in in the RecoJets_EventContent_cff, we will have to at least make a new Prompt version or wait until all PromptReco with pp is done to include this in the mainstream release.
The former is probably more feasible, but still not that desired.
Please put the definition of fixedGridRhoFastjetCentral in a separate file (in 74X only)
There was a problem hiding this comment.
Maybe if we're going to go that route we should just put this into any "silver" miniAOD file directly?
There was a problem hiding this comment.
maybe; it would also probably have a different src as well (packedCandidates)
There was a problem hiding this comment.
Yes, so maybe it's best to close this and do it via miniAOD or something else?
There was a problem hiding this comment.
it can stay open, just don't expect it to go far ;)
There are some requests building up for JetMET limited reprocessing in 74X, which may use this PR as well.
It's not clear to me still when and how that will be made (a branched-off special 74_1X release, probably)
There was a problem hiding this comment.
OK I will leave this "as is" and we can decide what to do later.
|
+1 Adding an eta-restricted (no HF) grid-based rho for future use in Mini-AOD or RECO. There should be no other change in monitored quantities. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_4_X_2015-10-13-1100 show no significant differences, as expected. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
cmsbuild
added
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
@davidlange6 |
…completely identical by mistake
David, |
|
@smuzaffar - something definitely went wrong here. Not sure what button I could have pushed to accomplish this? |
|
-1 |
As per request of PPD and the collaboration, this is the addition of an eta-restricted (no HF) grid-based rho. This can be used for miniAOD and/or future reco.