Changed static to const in ClusterFP420

[Dr15Jones]

The static analyzer found this.

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_6_X.

Changed static to const in ClusterFP420

It involves the following packages:

DataFormats/FP420Cluster

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test
[mainly sanity check point to compile]

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8784/console

[cmsbuild]

-1

Tested at: 4e85f6a
I found errors in the following unit tests:

---> test TestConfigDP had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11757/8784/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
2757e40
a9c569b
cf422a9
d0367c2
56c6f12
16aa87b
062e6f9
3f62079
ed469b2
9ba6d58
861e695
81b5cb9
c4d6c6d
e29a7b0
00b6389
38915aa
ed25f88
b955f7a
0679e84
0b1bdaa
741f882
560a615
9cac5c7
2cf46fc
2c551cf
65c6e3e
aecb870
1a2a5b4
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11757/8784/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11757/8784/git-merge-result

[cvuosalo]

+1

For #11757 4e85f6a

Making static variable const for thread safety in ClusterFP420, as reported by the static analyzer. There should be no change in run-time behavior.

The code changes are satisfactory, and the code compiles correctly. Jenkins tests are failing because of IB errors unrelated to this PR.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8859/console

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

+1
Tested at: 4e85f6a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11757/8859/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11757/8859/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar