Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing include of iostream #1143

Merged
merged 1 commit into from
Oct 22, 2013

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Oct 22, 2013

While working with ROOT6, I discovered 28 more CMSSW files that failed to compile because of a missing include of iostream. This pull request adds the missing include to each of these files. It also removes any remaining CVS tokens (e.g. $Id) in these files only.
Tested with checkdeps -a and the relvals.
Note, two of the affected files are header files, but cout is used explicitly in both headers, so the include is needed for the header to compile.
Please include this trivial technical fix in CMSSW_7_0_0_pre7, bypassing signatures if necessary to make pre7.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_0_X.

add missing include of iostream

It involves the following packages:

CondCore/ESSources
CondCore/ORA
CondCore/Utilities
CalibMuon/DTCalibration
CaloOnlineTools/HcalOnlineDb
CondCore/DTPlugins
CondTools/L1Trigger
CondTools/SiPixel
CondTools/DT
L1TriggerConfig/RCTConfigProducers
CondCore/DBOutputService
CondCore/IOVService
SimCalorimetry/EcalSelectiveReadoutProducers
CalibCalorimetry/CaloMiscalibTools

@smuzaffar, @apfeiffer1, @nclopezo, @demattia, @civanch, @mdhildreth, @rcastello, @giamman, @ggovi, @mulhearn can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@apfeiffer1
Copy link
Contributor

+1

On Tue, Oct 22, 2013 at 10:47 PM, cmsbuild [email protected] wrote:

A new Pull Request was created by @wmtan https://github.com/wmtan for
CMSSW_7_0_X.

add missing include of iostream

It involves the following packages:

CondCore/ESSources
CondCore/ORA
CondCore/Utilities
CalibMuon/DTCalibration
CaloOnlineTools/HcalOnlineDb
CondCore/DTPlugins
CondTools/L1Trigger
CondTools/SiPixel
CondTools/DT
L1TriggerConfig/RCTConfigProducers
CondCore/DBOutputService
CondCore/IOVService
SimCalorimetry/EcalSelectiveReadoutProducers
CalibCalorimetry/CaloMiscalibTools

@smuzaffar https://github.com/smuzaffar, @apfeiffer1https://github.com/apfeiffer1,
@nclopezo https://github.com/nclopezo, @demattiahttps://github.com/demattia,
@civanch https://github.com/civanch, @mdhildrethhttps://github.com/mdhildreth,
@rcastello https://github.com/rcastello, @giammanhttps://github.com/giamman,
@ggovi https://github.com/ggovi, @mulhearn https://github.com/mulhearncan you please review it and eventually sign? Thanks.
@ghellwig https://github.com/ghellwig this is something you requested
to watch as well.
You can sign-off by replying to this message having '+1' in the first line
of your reply.
You can reject by replying to this message having '-1' in the first line
of your reply.
@ktf https://github.com/ktf you are the release manager for this.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1143#issuecomment-26846174
.

Thanks,
cheers, andreas

@ktf
Copy link
Contributor

ktf commented Oct 22, 2013

Bypassing.

ktf added a commit that referenced this pull request Oct 22, 2013
ROOT6 -- Add missing include of iostream
@ktf ktf merged commit 7523fa9 into cms-sw:CMSSW_7_0_X Oct 22, 2013
@wmtan wmtan deleted the Missing_iostream_includes branch October 22, 2013 21:52
NJManganelli pushed a commit to NJManganelli/cmssw that referenced this pull request Jul 18, 2023
P2GMT: Disable hard-coding of debug printout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants