multithreading fix for 74x: CSC modules

[fwyzard]

Conversion of CLHEP matrices to ROOT::SMatrix in the CSC least-squares fit code of all 5 CSC segment building algorithms, for multithreading compatiiblity.

[fwyzard]

backport #7864 to 74x

[fwyzard]

tracked at #11317

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_4_X.

multithreading fix for 74x: CSC modules

It involves the following packages:

RecoLocalMuon/CSCSegment

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@bellan, @abbiendi, @jhgoh this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cvuosalo]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 6a4aebf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11393/8238/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11393/8238/summary.html

[fwyzard]

rebased to merge on top of both CMSSW_7_4_X and CMSSW_7_4_12_patch4

[fwyzard]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

Pull request #11393 was updated. @cmsbuild, @cvuosalo, @slava77 can you please check and sign again.

[cmsbuild]

+1
Tested at: 5751c57
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11393/8316/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11393/8316/summary.html

[slava77]

@fwyzard
you omitted RecoLocalMuon/CSCSegment/test/run_on_raw_75x.py and RecoLocalMuon/CSCSegment/test/run_on_simdigi_75x.py from the #7864
Was it intentional?

[slava77]

+1

for #11393 5751c57

• the same technical essential changes are applied in this PR as in CSC segment fit factored and smatrixed #7864 b779fc5 (integrated back in 750pre1)
  • two test files are omitted in the backport multithreading fix for 74x: CSC modules #11393 (comment). It should be OK.
• jenkins tests pass and comparisons with baseline show no differences as expected

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[fwyzard]

Yes, since this PR is for 74x I assumed we did non want them.

.A
On 25 Sep 2015 18:36, "Slava Krutelyov" [email protected] wrote:

@fwyzard https://github.com/fwyzard
you omitted RecoLocalMuon/CSCSegment/test/run_on_raw_75x.py and
RecoLocalMuon/CSCSegment/test/run_on_simdigi_75x.py from the #7864
#7864
Was it intentional?

—
Reply to this email directly or view it on GitHub
#11393 (comment).

[davidlange6]

+1