Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multithreading fix for 74x: L1GtTrigReport #11350

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Sep 18, 2015

Migrate summary modules

  • L1GtTrigReport
    to one::EDAnalyzer. They could be migrated to global::EDAnalyzer, but since we do not run them online it's probably not worth it.

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 18, 2015

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 18, 2015

tracked at #11317

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Sep 18, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_4_X.

L1GtTrigReport: change into a one::EDAnalyzer

It involves the following packages:

L1Trigger/GlobalTriggerAnalyzer

@cmsbuild, @mulhearn can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 21, 2015

backpot (part of) #11054 to 74x

@fwyzard fwyzard force-pushed the multithreading_74x_L1GtTrigReport branch from 9db9276 to 10fd9c3 Compare September 23, 2015 19:12
@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 23, 2015

rebased to merge on top of both CMSSW_7_4_X and CMSSW_7_4_12_patch4

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 23, 2015

please test

@fwyzard fwyzard changed the title L1GtTrigReport: change into a one::EDAnalyzer multithreading fix for 74x: L1GtTrigReport Sep 23, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #11350 was updated. @cmsbuild, @mulhearn can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

davidlange6 added a commit that referenced this pull request Oct 10, 2015
@davidlange6 davidlange6 merged commit 9d9f87f into cms-sw:CMSSW_7_4_X Oct 10, 2015
@fwyzard fwyzard deleted the multithreading_74x_L1GtTrigReport branch October 10, 2015 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants